From f0b953450aaf885d6b53c233e938d065bf231bbc Mon Sep 17 00:00:00 2001
From: Michael Nairn <mnairn@redhat.com>
Date: Wed, 22 Nov 2023 17:35:56 +0000
Subject: [PATCH] Add script to generate MetalLB IPAddressPool for docker
 network.

---
 Makefile                              |  1 +
 doc/user-guides/gateway-dns.md        | 27 -----------------------
 doc/user-guides/gateway-tls.md        | 29 +------------------------
 utils/docker-network-ipaddresspool.sh | 31 +++++++++++++++++++++++++++
 4 files changed, 33 insertions(+), 55 deletions(-)
 create mode 100755 utils/docker-network-ipaddresspool.sh

diff --git a/Makefile b/Makefile
index 32b2ab5f0..865691f59 100644
--- a/Makefile
+++ b/Makefile
@@ -379,6 +379,7 @@ undeploy-policy-controller: ## Undeploy policy-controller from the K8s cluster s
 install-metallb: $(KUSTOMIZE) ## Installs the metallb load balancer allowing use of an LoadBalancer type with a gateway
 	$(KUSTOMIZE) build config/metallb | kubectl apply -f -
 	kubectl -n metallb-system wait --for=condition=ready pod --selector=app=metallb --timeout=60s
+	./utils/docker-network-ipaddresspool.sh kind | kubectl apply -n metallb-system -f -
 
 .PHONY: uninstall-metallb
 uninstall-metallb: $(KUSTOMIZE) 
diff --git a/doc/user-guides/gateway-dns.md b/doc/user-guides/gateway-dns.md
index 8748aec98..4b20e46dd 100644
--- a/doc/user-guides/gateway-dns.md
+++ b/doc/user-guides/gateway-dns.md
@@ -36,33 +36,6 @@ Install metallb:
 make install-metallb
 ```
 
-Fetch the current kind networks subnet:
-```shell
-docker network inspect kind -f '{{ (index .IPAM.Config 0).Subnet }}'
-```
-Response:
-```shell
-"172.18.0.0/16"
-```
-
-Create IPAddressPool within kind network(Fetched by the command above) e.g. 172.18.200
-```shell
-kubectl -n metallb-system apply -f -<<EOF
-apiVersion: metallb.io/v1beta1
-kind: IPAddressPool
-metadata:
-  name: kuadrant-local
-spec:
-  addresses:
-  - 172.18.200.0/24
----
-apiVersion: metallb.io/v1beta1
-kind: L2Advertisement
-metadata:
-  name: empty
-EOF
-```
-
 Create a namespace:
 ```shell
 kubectl create namespace my-gateways
diff --git a/doc/user-guides/gateway-tls.md b/doc/user-guides/gateway-tls.md
index 0471ee9f4..991903493 100644
--- a/doc/user-guides/gateway-tls.md
+++ b/doc/user-guides/gateway-tls.md
@@ -35,33 +35,6 @@ Install metallb:
 make install-metallb
 ```
 
-Fetch the current kind networks subnet:
-```shell
-docker network inspect kind -f '{{ (index .IPAM.Config 0).Subnet }}'
-```
-Response:
-```shell
-"172.18.0.0/16"
-```
-
-Create IPAddressPool within kind network(Fetched by the command above) e.g. 172.18.200
-```shell
-kubectl -n metallb-system apply -f -<<EOF
-apiVersion: metallb.io/v1beta1
-kind: IPAddressPool
-metadata:
-  name: kuadrant-local
-spec:
-  addresses:
-  - 172.18.200.0/24
----
-apiVersion: metallb.io/v1beta1
-kind: L2Advertisement
-metadata:
-  name: empty
-EOF
-```
-
 Create a namespace:
 ```shell
 kubectl create namespace my-gateways
@@ -204,7 +177,7 @@ EOF
 
 Verify we can access the service via TLS:
 ```shell
-curl -k https://api.toystore.local --resolve 'api.toystore.local:443:172.18.200.0'
+curl -vkI https://api.toystore.local --resolve 'api.toystore.local:443:172.18.200.0'
 ```
 
 ## Cleanup
diff --git a/utils/docker-network-ipaddresspool.sh b/utils/docker-network-ipaddresspool.sh
new file mode 100755
index 000000000..e7297de57
--- /dev/null
+++ b/utils/docker-network-ipaddresspool.sh
@@ -0,0 +1,31 @@
+#!/bin/bash
+
+# Generates a MetalLB IpAddressPool for the given docker network.
+# https://metallb.org/configuration/#defining-the-ips-to-assign-to-the-load-balancer-services
+#
+# Example:
+# ./utils/docker-network-ipaddresspool.sh kind | kubectl apply -n metallb-system -f -
+
+set -euo pipefail
+
+networkName=$1
+
+subnet=`docker network inspect $networkName -f '{{ (index .IPAM.Config 0).Subnet }}'`
+# shellcheck disable=SC2206
+subnetParts=(${subnet//./ })
+cidr="${subnetParts[0]}.${subnetParts[1]}.200.0/24"
+
+cat <<EOF
+apiVersion: metallb.io/v1beta1
+kind: IPAddressPool
+metadata:
+  name: kuadrant-local
+spec:
+  addresses:
+  - $cidr
+---
+apiVersion: metallb.io/v1beta1
+kind: L2Advertisement
+metadata:
+  name: empty
+EOF