From a5376a17c19510a258e51989fe7bd8fdb3373622 Mon Sep 17 00:00:00 2001 From: Michael Nairn Date: Tue, 21 Jan 2025 22:02:25 +0000 Subject: [PATCH] fix: Google dns provider metrics name key The google providers instrumented client has the name "google" and not "gcp", so no google provider metrics are currently appearing on the grafana dashboard https://github.com/Kuadrant/dns-operator/blob/main/internal/provider/google/google.go#L131 Signed-off-by: Michael Nairn --- examples/dashboards/dns-operator.json | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/examples/dashboards/dns-operator.json b/examples/dashboards/dns-operator.json index db365658d..f996f0249 100644 --- a/examples/dashboards/dns-operator.json +++ b/examples/dashboards/dns-operator.json @@ -469,7 +469,7 @@ "uid": "${datasource}" }, "editorMode": "code", - "expr": "histogram_quantile(0.99, sum by(le, client) (rate(http_client_request_latency_seconds_bucket{client=~\"aws|gcp|azure\",code=\"200\"}[15m])))", + "expr": "histogram_quantile(0.99, sum by(le, client) (rate(http_client_request_latency_seconds_bucket{client=~\"aws|google|azure\",code=\"200\"}[15m])))", "legendFormat": "{{client}}:99%ile", "range": true, "refId": "A" @@ -480,7 +480,7 @@ "uid": "${datasource}" }, "editorMode": "code", - "expr": "histogram_quantile(0.95, sum by(le, client) (rate(http_client_request_latency_seconds_bucket{client=~\"aws|gcp|azure\",code=\"200\"}[15m])))", + "expr": "histogram_quantile(0.95, sum by(le, client) (rate(http_client_request_latency_seconds_bucket{client=~\"aws|google|azure\",code=\"200\"}[15m])))", "hide": false, "legendFormat": "{{client}}:95%ile", "range": true, @@ -571,7 +571,7 @@ "uid": "${datasource}" }, "editorMode": "code", - "expr": "sum by (client, code) (rate(http_client_requests_total{client=~\"aws|gcp|azure\"}[15m]))", + "expr": "sum by (client, code) (rate(http_client_requests_total{client=~\"aws|google|azure\"}[15m]))", "hide": false, "legendFormat": "{{client}}:{{code}}", "range": true,