Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check kumsg transfer amount and data amount #24

Conversation

aries-kuchain
Copy link
Contributor

Summary

fix KuChainNetwork/Project-Deluge#17

Introduction

When there is transfer in kumsg, the amount of transfer and the amount required in msgdata can be constructed differently, which will cause the risk of currency theft, and increase the verification of whether the amount of transfer and the amount of msgdata are equal to avoid this problem

Add the corresponding test case

Modifys

  • gov/types/kumsg.go KuMsgSubmitProposal
  • gov/types/kumsg.go KuMsgDeposit
  • staking/types/kumsg.go KuMsgDelegate
  • staking/handle_test.go
  • gov/handle_test.go

@aquarius-kuchain aquarius-kuchain added the bug Something isn't working label Aug 5, 2020
@aquarius-kuchain aquarius-kuchain merged commit bcd1ddd into KuChainNetwork:develop Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Malicious user can steal token from kugov by deposit in gov module.
2 participants