diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 299694e8..9732e7d8 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -137,13 +137,6 @@ jobs: working-directory: ${{ env.ROOT_DIR }} run: wp-cli plugin install ${{ env.INSTALL_PLUGINS_URLS }} - # Activates the Disable `_load_textdomain_just_in_time` `doing_it_wrong` notice Plugin, - # to prevent _load_textdomain_just_in_time PHP notices in WordPress 6.7+ due to third - # party Plugins. - - name: Activate "Disable `_load_textdomain_just_in_time` `doing_it_wrong` notice Plugin" - working-directory: ${{ env.ROOT_DIR }} - run: wp-cli plugin activate disable-doing-it-wrong-notices.php - # These should be stored as a separated list of URLs in the repository Settings > Secrets > Repository Secret > CONVERTKIT_PAID_PLUGIN_URLS. # We cannot include the URLs in this file, as they're not Plugins we are permitted to distribute. - name: Install Paid Third Party WordPress Plugins diff --git a/tests/acceptance/forms/blocks-shortcodes/PageShortcodeFormCest.php b/tests/acceptance/forms/blocks-shortcodes/PageShortcodeFormCest.php index 6e029610..f70beb45 100644 --- a/tests/acceptance/forms/blocks-shortcodes/PageShortcodeFormCest.php +++ b/tests/acceptance/forms/blocks-shortcodes/PageShortcodeFormCest.php @@ -655,6 +655,7 @@ public function testFormShortcodeWithPerfmattersPlugin(AcceptanceTester $I) $I->setupConvertKitPluginResources($I); // Activate Perfmatters Plugin. + $I->activateThirdPartyPlugin($I, 'disable-_load_textdomain_just_in_time-doing_it_wrong-notice'); $I->activateThirdPartyPlugin($I, 'perfmatters'); // Enable Defer and Delay JavaScript. @@ -700,6 +701,7 @@ public function testFormShortcodeWithPerfmattersPlugin(AcceptanceTester $I) // Deactivate Perfmatters Plugin. $I->deactivateThirdPartyPlugin($I, 'perfmatters'); + $I->deactivateThirdPartyPlugin($I, 'disable-_load_textdomain_just_in_time-doing_it_wrong-notice'); } /** @@ -770,6 +772,7 @@ public function testFormShortcodeWithWPRocketPlugin(AcceptanceTester $I) $I->setupConvertKitPluginResources($I); // Activate WP Rocket Plugin. + $I->activateThirdPartyPlugin($I, 'disable-_load_textdomain_just_in_time-doing_it_wrong-notice'); $I->activateThirdPartyPlugin($I, 'wp-rocket'); // Configure WP Rocket. @@ -806,6 +809,7 @@ public function testFormShortcodeWithWPRocketPlugin(AcceptanceTester $I) // Deactivate WP Rocket Plugin. $I->deactivateThirdPartyPlugin($I, 'wp-rocket'); + $I->deactivateThirdPartyPlugin($I, 'disable-_load_textdomain_just_in_time-doing_it_wrong-notice'); } /** diff --git a/tests/acceptance/integrations/other/DiviBroadcastsCest.php b/tests/acceptance/integrations/other/DiviBroadcastsCest.php index a1ea5990..38eb78dc 100644 --- a/tests/acceptance/integrations/other/DiviBroadcastsCest.php +++ b/tests/acceptance/integrations/other/DiviBroadcastsCest.php @@ -16,6 +16,7 @@ class DiviBroadcastsCest public function _before(AcceptanceTester $I) { $I->activateConvertKitPlugin($I); + $I->activateThirdPartyPlugin($I, 'disable-_load_textdomain_just_in_time-doing_it_wrong-notice'); $I->activateThirdPartyPlugin($I, 'divi-builder'); } @@ -173,6 +174,7 @@ public function testBroadcastsModuleInFrontendEditorWhenNoBroadcasts(AcceptanceT public function _passed(AcceptanceTester $I) { $I->deactivateThirdPartyPlugin($I, 'divi-builder'); + $I->deactivateThirdPartyPlugin($I, 'disable-_load_textdomain_just_in_time-doing_it_wrong-notice'); $I->deactivateConvertKitPlugin($I); $I->resetConvertKitPlugin($I); } diff --git a/tests/acceptance/integrations/other/DiviFormCest.php b/tests/acceptance/integrations/other/DiviFormCest.php index 41aa4e42..e05178f7 100644 --- a/tests/acceptance/integrations/other/DiviFormCest.php +++ b/tests/acceptance/integrations/other/DiviFormCest.php @@ -16,6 +16,7 @@ class DiviFormCest public function _before(AcceptanceTester $I) { $I->activateConvertKitPlugin($I); + $I->activateThirdPartyPlugin($I, 'disable-_load_textdomain_just_in_time-doing_it_wrong-notice'); $I->activateThirdPartyPlugin($I, 'divi-builder'); } @@ -228,6 +229,7 @@ public function testFormModuleWithNoFormParameter(AcceptanceTester $I) public function _passed(AcceptanceTester $I) { $I->deactivateThirdPartyPlugin($I, 'divi-builder'); + $I->deactivateThirdPartyPlugin($I, 'disable-_load_textdomain_just_in_time-doing_it_wrong-notice'); $I->deactivateConvertKitPlugin($I); $I->resetConvertKitPlugin($I); } diff --git a/tests/acceptance/integrations/other/DiviFormTriggerCest.php b/tests/acceptance/integrations/other/DiviFormTriggerCest.php index b4b92e6d..4cce1333 100644 --- a/tests/acceptance/integrations/other/DiviFormTriggerCest.php +++ b/tests/acceptance/integrations/other/DiviFormTriggerCest.php @@ -16,6 +16,7 @@ class DiviFormTriggerCest public function _before(AcceptanceTester $I) { $I->activateConvertKitPlugin($I); + $I->activateThirdPartyPlugin($I, 'disable-_load_textdomain_just_in_time-doing_it_wrong-notice'); $I->activateThirdPartyPlugin($I, 'divi-builder'); } @@ -193,6 +194,7 @@ public function testFormTriggerModuleWithNoFormParameter(AcceptanceTester $I) public function _passed(AcceptanceTester $I) { $I->deactivateThirdPartyPlugin($I, 'divi-builder'); + $I->deactivateThirdPartyPlugin($I, 'disable-_load_textdomain_just_in_time-doing_it_wrong-notice'); $I->deactivateConvertKitPlugin($I); $I->resetConvertKitPlugin($I); } diff --git a/tests/acceptance/integrations/other/DiviProductCest.php b/tests/acceptance/integrations/other/DiviProductCest.php index 5e0e4b59..ebc7f47f 100644 --- a/tests/acceptance/integrations/other/DiviProductCest.php +++ b/tests/acceptance/integrations/other/DiviProductCest.php @@ -16,6 +16,7 @@ class DiviProductCest public function _before(AcceptanceTester $I) { $I->activateConvertKitPlugin($I); + $I->activateThirdPartyPlugin($I, 'disable-_load_textdomain_just_in_time-doing_it_wrong-notice'); $I->activateThirdPartyPlugin($I, 'divi-builder'); } @@ -186,6 +187,7 @@ public function testProductModuleWithNoProductParameter(AcceptanceTester $I) public function _passed(AcceptanceTester $I) { $I->deactivateThirdPartyPlugin($I, 'divi-builder'); + $I->deactivateThirdPartyPlugin($I, 'disable-_load_textdomain_just_in_time-doing_it_wrong-notice'); $I->deactivateConvertKitPlugin($I); $I->resetConvertKitPlugin($I); } diff --git a/tests/acceptance/landing-pages/PageLandingPageCest.php b/tests/acceptance/landing-pages/PageLandingPageCest.php index 21d921b3..41160d05 100644 --- a/tests/acceptance/landing-pages/PageLandingPageCest.php +++ b/tests/acceptance/landing-pages/PageLandingPageCest.php @@ -328,6 +328,7 @@ public function testAddNewPageUsingDefinedLandingPageWithPerfmattersPlugin(Accep $I->setupConvertKitPluginResources($I); // Activate Perfmatters Plugin. + $I->activateThirdPartyPlugin($I, 'disable-_load_textdomain_just_in_time-doing_it_wrong-notice'); $I->activateThirdPartyPlugin($I, 'perfmatters'); // Enable Lazy Loading. @@ -373,6 +374,7 @@ public function testAddNewPageUsingDefinedLandingPageWithPerfmattersPlugin(Accep // Deactivate Perfmatters Plugin. $I->deactivateThirdPartyPlugin($I, 'perfmatters'); + $I->deactivateThirdPartyPlugin($I, 'disable-_load_textdomain_just_in_time-doing_it_wrong-notice'); } /**