From cc168172b46ccfe463327f13cad79f1263ca26f2 Mon Sep 17 00:00:00 2001 From: Neil Kalman Date: Sat, 12 Oct 2024 22:13:46 +0000 Subject: [PATCH] small nits --- .devcontainer/devcontainer.json | 4 ++-- .vscode/settings.json | 3 ++- scripts/create-github-app.script.ts | 4 +++- scripts/create-github-oauth.script.ts | 4 +++- 4 files changed, 10 insertions(+), 5 deletions(-) diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json index 0367aa2..fb0f33c 100644 --- a/.devcontainer/devcontainer.json +++ b/.devcontainer/devcontainer.json @@ -1,5 +1,5 @@ { - "name": "achievibit-dev-container", + "name": "achievibit-devcontainer", "dockerComposeFile": "docker-compose.dev.yml", "service": "app", "workspaceFolder": "/workspace", @@ -43,7 +43,7 @@ } } }, - "postCreateCommand": "pnpm install", + "postCreateCommand": "pnpm install --force", "remoteEnv": { "NODE_ENV": "devcontainer", "PUPPETEER_SKIP_DOWNLOAD": "false", diff --git a/.vscode/settings.json b/.vscode/settings.json index 0e2d388..d8037ad 100644 --- a/.vscode/settings.json +++ b/.vscode/settings.json @@ -177,5 +177,6 @@ "**/*.txt", "**/*.rb", "**/*.go" - ] + ], + "angular.enable-strict-mode-prompt": false } \ No newline at end of file diff --git a/scripts/create-github-app.script.ts b/scripts/create-github-app.script.ts index 12bd366..4875ead 100644 --- a/scripts/create-github-app.script.ts +++ b/scripts/create-github-app.script.ts @@ -20,7 +20,9 @@ import { chromium } from '@playwright/test'; // open browser const browser = await chromium.launch({ headless: false, - slowMo: 500 + slowMo: 500, + // Required for running inside containers + args: [ '--no-sandbox', '--disable-setuid-sandbox' ] }); const page = await browser.newPage(); page.setDefaultTimeout(240000); diff --git a/scripts/create-github-oauth.script.ts b/scripts/create-github-oauth.script.ts index 850781d..3b65d23 100644 --- a/scripts/create-github-oauth.script.ts +++ b/scripts/create-github-oauth.script.ts @@ -16,7 +16,9 @@ import { chromium } from '@playwright/test'; // open browser const browser = await chromium.launch({ headless: false, - slowMo: 1000 + slowMo: 1000, + // Required for running inside containers + args: [ '--no-sandbox', '--disable-setuid-sandbox' ] }); const page = await browser.newPage(); page.setDefaultTimeout(240000);