Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter in domain analyser #3230

Closed
Jeffrey-F1solutions opened this issue Jan 14, 2025 · 8 comments
Closed

Filter in domain analyser #3230

Jeffrey-F1solutions opened this issue Jan 14, 2025 · 8 comments
Labels
bug Something isn't working unconfirmed-by-user

Comments

@Jeffrey-F1solutions
Copy link

Description

  1. open domain analyser
  2. click on preset filter
  3. only reset filter is being shown, no exclude onmicrosoft

Screenshot:
image

Expected:
image

The new update looks great!

Environment data

Non-sponsored
frontend 7.0.2
backend 7.0.2
@Jeffrey-F1solutions Jeffrey-F1solutions added bug Something isn't working unconfirmed-by-user labels Jan 14, 2025
Copy link

Thank you for creating a bug. Please make sure your bug is indeed a unique case by checking current and past issues, and reading the complete documentation at https://docs.cipp.app/
If your bug is a known documentation issue, it will be closed without notice by a contributor. To confirm that this is not a bug found in the documentation, please copy and paste the following comment: "I confirm that I have checked the documentation thoroughly and believe this to be an actual bug."

Without confirming, your report will be closed in 24 hours. If you'd like this bug to be assigned to you, please comment "I would like to work on this please!".

@kris6673
Copy link
Contributor

I would like to work on this please!

Copy link

Great! I assigned you (@kris6673) to the issue. Have fun working on it!

@markheydon
Copy link

@kris6673 I believe this is more widespread than just the Domain Analyser screen as every list I've looked at so far since upgrade also has this issue.

@kris6673
Copy link
Contributor

Yep @markheydon, just realizing this now too.
I think the new tables lost support for "notlike" and "notcontains" and a lot of our filters used that.
I'm not well versed in the new rewrite yet to fix this, so I'm gonna unassign myself again and let the adults handle this

@kris6673 kris6673 removed their assignment Jan 14, 2025
@Jeffrey-F1solutions
Copy link
Author

I confirm that I have checked the documentation thoroughly and believe this to be an actual bug.

@KelvinTegelaar
Copy link
Owner

You can use the filter button to create this filter yourself. Click the filter button, then flick the filter option list next to input box and select "not".

Not a bug, but a feature request:

Thank you for your interest in improving CIPP! To keep our development process focused and manageable, feature requests are limited to paying users. This policy helps us prioritize improvements that directly benefit those actively supporting CIPP and ensure we can sustain our development and support.

When a sponsor makes a feature request, their support covers training, development, documentation, and security checks. Allowing non-sponsor requests could lead to a backlog that would slow down updates and stretch resources thin, ultimately impacting the quality and sustainability of CIPP.

While we’ve closed this request, we appreciate your input, and you’re always welcome to participate in ongoing discussions or contribute to open issues. If you are a developer yourself, feel free to create a PR that includes your feature request or type "I'd like to work on this!" to assign the issue to yourself.

Did you get this notification in error? Reply with a screenshot of your sponsorship payment and we'll reopen the issue.

Thank you for understanding,
The CIPP Team

@markheydon
Copy link

You can use the filter button to create this filter yourself. Click the filter button, then flick the filter option list next to input box and select "not".

Not a bug, but a feature request:

How do you then save the filter @KelvinTegelaar ? Or are you saying you can't and that a Feature Request should be raised to add this feature of creating your own filters?

image

Screenshot is from the Groups screen, where also no Preset Filters showing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working unconfirmed-by-user
Projects
None yet
Development

No branches or pull requests

4 participants