Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFFSelectSearch fields do not show validation errors visually #1833

Closed
sk1tt1sh opened this issue Oct 26, 2023 · 3 comments
Closed

RFFSelectSearch fields do not show validation errors visually #1833

sk1tt1sh opened this issue Oct 26, 2023 · 3 comments
Labels
bug Something isn't working unconfirmed-by-user

Comments

@sk1tt1sh
Copy link

Description

  1. Go to Add User in Identity
  2. Fill out all fields except the usage location
  3. Hit submit
  4. The Usage Location field does not pass validation and the page shows all fields with green checks, except Usage Location which remains unchanged.

I tested locally and updated src/components/forms/RFFComponents.js RFFSelectSearch from:
<div><CFormLabel/>...<RFFCFormFeedback meta={meta} /></div>
to:
<div><CFormLabel/>...{meta.error && meta.touched && <span className="text-danger">{meta.error}</span>}</div>

Tried again and red "Required" showed underneath the field.

Not working:
image

With my change:
image

Environment data

Non-sponsored instance Front end version number: 4.4.0
Back end version number: 4.4.5
Tried Tenant Cache Clear: true
Tried Token Cache Clear: true
@sk1tt1sh sk1tt1sh added bug Something isn't working unconfirmed-by-user labels Oct 26, 2023
@github-actions
Copy link

Thank you for creating a bug. Please make sure your bug is indeed a unique case by checking current and past issues, and reading the complete documentation at https://docs.cipp.app/
If your bug is a known documentation issue, it will be closed without notice by a contributor. To confirm that this is not a bug found in the documentation, please copy and paste the following comment: "I confirm that I have checked the documentation thoroughly and believe this to be an actual bug.".

Without confirming, your report will be closed in 24 hours. If you'd like this bug to be assigned to you, please comment "I would like to work on this please!".

@sk1tt1sh
Copy link
Author

sk1tt1sh commented Oct 27, 2023

I have updated to 4.5.0 frontend and backend, since submitting this issue and the behavior continues.

@sk1tt1sh
Copy link
Author

I confirm that I have checked the documentation thoroughly and believe this to be an actual bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working unconfirmed-by-user
Projects
None yet
Development

No branches or pull requests

2 participants