Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Total Licensing Count is Incorrect #1817

Closed
gconsultingadmin opened this issue Oct 19, 2023 · 6 comments
Closed

Total Licensing Count is Incorrect #1817

gconsultingadmin opened this issue Oct 19, 2023 · 6 comments
Labels

Comments

@gconsultingadmin
Copy link

Description

  1. select All Tenants from dropdown menu
  2. Go to Reports > Licence Report

The license total is incorrect for customer who have a combination of monthly and yearly licensing.
image

Environment data

Non-sponsored instance
Front end version number: 4.4.0
Back end version number: 4.4.0
Tried Tenant Cache Clear: false
Tried Token Cache Clear: false
@gconsultingadmin gconsultingadmin added bug Something isn't working unconfirmed-by-user labels Oct 19, 2023
@github-actions
Copy link

Thank you for creating a bug. Please make sure your bug is indeed a unique case by checking current and past issues, and reading the complete documentation at https://docs.cipp.app/
If your bug is a known documentation issue, it will be closed without notice by a contributor. To confirm that this is not a bug found in the documentation, please copy and paste the following comment: "I confirm that I have checked the documentation thoroughly and believe this to be an actual bug.".

Without confirming, your report will be closed in 24 hours. If you'd like this bug to be assigned to you, please comment "I would like to work on this please!".

@gconsultingadmin
Copy link
Author

I confirm that I have checked the documentation thoroughly and believe this to be an actual bug.

@github-actions
Copy link

This issue is stale because it has been open 10 days with no activity. We will close this issue soon. If you want this feature implemented you can contribute it. See: https://cipp.app/GettingStarted/Contributions/ . Please notify the team if you are working on this yourself.

@KelvinTegelaar
Copy link
Owner

Fixed in dev

@gconsultingadmin
Copy link
Author

gconsultingadmin commented Dec 6, 2023

I'm still having this same issue, is there anything I should check? @KelvinTegelaar

@gconsultingadmin
Copy link
Author

@KelvinTegelaar

The issue is this line:
https://github.com/KelvinTegelaar/CIPP-API/blob/73e032d6f29e1777d21e0062765927b76a392bfe/Modules/CIPPCore/Public/Get-CIPPLicenseOverview.ps1#L58

I added " - $($Term)" to the naming of the rowkey, so that monthly/yearly rows do not overwrite each other.

jwguidry-vital added a commit to jwguidry-vital/CIPP-API that referenced this issue Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants