Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account Duplication Problem in Gradient MSP Integration #1808

Closed
gradientbryan opened this issue Oct 16, 2023 · 4 comments
Closed

Account Duplication Problem in Gradient MSP Integration #1808

gradientbryan opened this issue Oct 16, 2023 · 4 comments
Labels
bug Something isn't working unconfirmed-by-user

Comments

@gradientbryan
Copy link

gradientbryan commented Oct 16, 2023

Description

Accounts are duplicating because there's no unique identifier for them.

Problem with Synthesize integration during account creation. Accounts are getting duplicated because the description is being used as the "ID," and the description contains the domains of the M365 tenant. Since it's common to have multiple domains for a tenant, we end up with duplicate companies being created.

We need to identify an alternative unique identifier source to avoid creating multiple accounts and ensure that usage is synced correctly for each tenant.

Example, we are returning duplicate accounts in Synthesize, and the "ID" appears to be the description or domain:

Account 1:

Name: "ABC Corporation"
Description: "abccsrporation.onmicrosoft.com"
Account 2:

Name: "ABC Corporation"
Description: "abccorporation.com"

We need to identify an alternative unique identifier source to prevent such duplicates and ensure accurate usage syncing for each tenant.

Environment data

Sponsored instance
@gradientbryan gradientbryan added bug Something isn't working unconfirmed-by-user labels Oct 16, 2023
@github-actions
Copy link

Thank you for creating a bug. Please make sure your bug is indeed a unique case by checking current and past issues, and reading the complete documentation at https://docs.cipp.app/
If your bug is a known documentation issue, it will be closed without notice by a contributor. To confirm that this is not a bug found in the documentation, please copy and paste the following comment: "I confirm that I have checked the documentation thoroughly and believe this to be an actual bug.".

Without confirming, your report will be closed in 24 hours. If you'd like this bug to be assigned to you, please comment "I would like to work on this please!".

@KelvinTegelaar
Copy link
Owner

Looking into this without breaking existing integrations. Normally the defaultDomainName does not change as it's only retrieved once. The user that reported this changed the partner center connection too so we'll have to find a nice way to handle that. :)

@gradientbryan
Copy link
Author

Good to know! I figured there was a fringe case here, but it's good to know you're using the defaultDomainName as your identifier here.

@KelvinTegelaar
Copy link
Owner

Resolved in dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working unconfirmed-by-user
Projects
None yet
Development

No branches or pull requests

2 participants