Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Standards - Enable Microsoft OTP in Auth methods #1789

Closed
kris6673 opened this issue Oct 6, 2023 · 4 comments
Closed
Labels
enhancement New feature or request no-priority

Comments

@kris6673
Copy link
Contributor

kris6673 commented Oct 6, 2023

Description of the new feature - must be an in-depth explanation of the feature you want, reasoning why, and the added benefits for MSPs as a whole.

Many of our customers are using the MS NPS extension for VPN authendication and after number matching has become mandatory, now rely on the OTP code from the Authendicator app instead of getting a push notification. The current CIPP standard "Enable Passwordless with Location information and Number Matching" changes this to Disabled everytime standards run.

Having a dropdown to chose if it should be enabled or disabled like with "Set Authenticator Lite state" would be nice.
Default set to "No" for backwards compatability.

Since the feature is locked behind registering the Authendicator app and this is just an add-on, it should not decrease security. At least to my knowledge.

PowerShell commands you would normally use to achieve above request

This is your own code, only part modified is: "isSoftwareOathEnabled" being set to true instead of false

try {
    $body = @"
{"@odata.type":"#microsoft.graph.microsoftAuthenticatorAuthenticationMethodConfiguration","id":"MicrosoftAuthenticator","includeTargets":[{"id":"all_users","isRegistrationRequired":false,"targetType":"group","authenticationMode":"any"}],"excludeTargets":[],"state":"enabled","isSoftwareOathEnabled":true,"featureSettings":{"displayLocationInformationRequiredState":{"state":"enabled","includeTarget":{"id":"all_users","targetType":"group","displayName":"All users"}},"displayAppInformationRequiredState":{"state":"enabled","includeTarget":{"id":"all_users","targetType":"group","displayName":"All users"}},"companionAppAllowedState":{"state":"default","includeTarget":{"id":"all_users","targetType":"group","displayName":"All users"}}}}
"@
    (New-GraphPostRequest -tenantid $tenant -Uri "https://graph.microsoft.com/beta/policies/authenticationMethodsPolicy/authenticationMethodConfigurations/microsoftAuthenticator" -Type patch -Body $body -ContentType "application/json")

    Write-LogMessage  -API "Standards" -tenant $tenant -message "Enabled passwordless with Information and Number Matching." -sev Info
}
catch {
    Write-LogMessage  -API "Standards" -tenant $tenant -message "Failed to enable passwordless with Information and Number Matching. Error: $($_.exception.message)" -sev "Error"
}
@kris6673 kris6673 added enhancement New feature or request no-priority labels Oct 6, 2023
@github-actions
Copy link

github-actions bot commented Oct 6, 2023

Thank you for creating a feature request!
Your current priority is set to "No Priority". No Priority Feature requests automatically get closed in two days if a contributor does not accept the FR.

If you are a sponsor you can request an upgrade of priority. To upgrade the priority type "I would like to upgrade the priority".
If you want this feature to be integrated you can always do this yourself by checking out our contributions guide at https://cipp.app/docs/dev/. Contributors to the CIPP project reserve the right to close feature requests at will.
If you'd like this feature request to be assigned to you, please comment "I would like to work on this please!".

@KelvinTegelaar
Copy link
Owner

KelvinTegelaar commented Oct 6, 2023

only sponsors can create FRs,

@KelvinTegelaar
Copy link
Owner

Added in dev; we no longer send that in the patch at all, so users can decide themselves if to enable/not.

@kris6673
Copy link
Contributor Author

Added in dev; we no longer send that in the patch at all, so users can decide themselves if to enable/not.

Awesome thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request no-priority
Projects
None yet
Development

No branches or pull requests

2 participants