Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update more keywords to be weighted when making combo #20

Open
abhimat opened this issue Oct 14, 2022 · 0 comments
Open

Update more keywords to be weighted when making combo #20

abhimat opened this issue Oct 14, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@abhimat
Copy link
Contributor

abhimat commented Oct 14, 2022

When making the combo image, the values for only the MJD-OBS and the DATE keywords in the final combo image file are updated with the weights. Additional keywords should also be updated to reflect the final weighted value.

Currently, almost all keywords' values in the combo file header are coming from the combo epoch's reference image, which is just the lowest FWHM frame going into the combo. This reference file is what is used for the base when drizzling and all FITS header keywords are just kept from the reference image file.

The following keywords should be updated with the weights:

  • EXPSTART and EXPSTOP
  • PMSANGL (and other pupil keywords?)
  • Rotator angle keywords (e.g., ROTPOSN)?

I can make this change; making it into an issue so we can track it and possibly discuss any other keywords that may make sense to apply the weights to when we're saving out the final combo image. Weighted exposure time and pupil keywords will be helpful for applying AIROPA variable-PSF mode (as suggested by @skterry)!

@abhimat abhimat self-assigned this Oct 14, 2022
@abhimat abhimat added the enhancement New feature or request label Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant