Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Distinguish containers in .gitconfig user name #38

Closed
HebaruSan opened this issue Sep 24, 2019 · 1 comment · Fixed by #39
Closed

[Feature] Distinguish containers in .gitconfig user name #38

HebaruSan opened this issue Sep 24, 2019 · 1 comment · Fixed by #39
Labels
Enhancement New feature or request

Comments

@HebaruSan
Copy link
Member

HebaruSan commented Sep 24, 2019

Problem

While investigating #33 and #36, it's hard to tell which commits are from the Indexer, which from the web hooks, and which from the download counter. The author is always just NetKAN inflator Robot regardless of the container of origin.

Suggestions

Describe the solution you'd like

Make this name container-specific:

[user]
email = [email protected]
name = NetKAN inflator Robot

Suggestions:

  • NetKAN Robotic Indexer
  • NetKAN Robotic Download Counter
  • NetKAN Web Hook

Then the git history would tell us who did what more clearly.

@HebaruSan HebaruSan added the Enhancement New feature or request label Sep 24, 2019
@techman83
Copy link
Member

We could, though I expect in the fullness of time the Indexer itself will take charge of all the commits. It can basically consume any changes faster than anything else producing them, so changes are always going to be near real time. It will reduce the amount of merge commits and any fights over who does what.

The Download Counter could submit them too, but currently the indexer assumes a ckan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants