Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sap Flow development #23

Open
2 of 4 tasks
mmaelicke opened this issue Feb 17, 2021 · 1 comment
Open
2 of 4 tasks

Sap Flow development #23

mmaelicke opened this issue Feb 17, 2021 · 1 comment
Assignees
Labels
sap flow Anything that corresponds to the sap flow submodule
Milestone

Comments

@mmaelicke
Copy link
Member

mmaelicke commented Feb 17, 2021

This is the missing stuff from #20:

General function layout for sap flow tools.
I provided the main functions in sap_flow.py and utility and correction functions in util.py.

ToDo

  • add descriptions to all docstrings
  • check the parameters for data type and possible default values
  • add data example, write unittests
  • implement the code
@mmaelicke mmaelicke added the sap flow Anything that corresponds to the sap flow submodule label Feb 17, 2021
@mmaelicke mmaelicke added this to the 0.3 Version milestone Feb 17, 2021
@mmaelicke
Copy link
Member Author

Missing docstrings:

def sap_velocity(method='East30_3needle', **kwargs):

def sapwood_area(dbh: float, species: str, sapwood_depth=None, bark_depth=None, **kwargs) -> float:

[Description]

# TODO ducoment why we do this

add a short sentence to:

def _sapwood_area_gebauer(dbh: float, species: str, **kwargs) -> float:

def __estimate_bark_depth(dbh: float, species: str, bark_depth=None) -> float:

def __sap_flow_profile(As, vs, depths, dbh: float, species: str, bark_depth=None, sapwood_depth=None):

def __estimate_last_chunk(dbh: float, species: str, upper_depth, sapwood_depth=None, bark_depth=None) -> float:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sap flow Anything that corresponds to the sap flow submodule
Projects
None yet
Development

No branches or pull requests

2 participants