Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show contact links - point to ./contact #206

Open
gerbrent opened this issue Aug 2, 2022 · 7 comments
Open

Show contact links - point to ./contact #206

gerbrent opened this issue Aug 2, 2022 · 7 comments
Assignees
Labels
enhancement New feature, enhancement, or request UX related to user experience
Milestone

Comments

@gerbrent
Copy link
Collaborator

gerbrent commented Aug 2, 2022

Now that we have a contact page thanks to #139, I believe it would be logical to point the Show pages to have the "Contact" link point to https://jupiterbroadcasting.net/contact/ instead of, say, https://coder.show/contact

it would mean:

  • losing the functionality of having the show be auto-chosen for feedback (listeners would have to explicitly choose say Coder Radio from the dropdown menu)
  • improved UX: not having listeners be taken away from the main JB site

I believe that's an acceptable compromise. Thoughts? Open to feedback, as always.

@gerbrent gerbrent added enhancement New feature, enhancement, or request good first issue Good for newcomers UX related to user experience feedback requested labels Aug 2, 2022
@gerbrent gerbrent added this to the JB.com 1.0 milestone Aug 2, 2022
@reesericci
Copy link
Collaborator

The link on the show page could pass a url query parameter which could be parsed with some JS to automatically fill the form with the right show.

@Lord0fBytes
Copy link
Contributor

I think this is even easier with WuFoo. They allow URL pre-loading in their forms. @gerbrent if you can get me the API_IDs I can test this out to see if the URL modification will work for our purposes.
Source: https://help.wufoo.com/articles/en_US/kb/URL-Modifications

My idea is that we use the contact link like this: https://jblive.wufoo.com/embed/w7x2r7/def/field1=coder-radio (where field1 is the API_ID). It would be a pretty easy re-write on the Hugo side since that can be dynamically inserted.

@gerbrent
Copy link
Collaborator Author

gerbrent commented Aug 5, 2022

LOVE this. Stay tuned....

@gerbrent gerbrent added JB - action needed action needed from a JB Team member and removed good first issue Good for newcomers feedback requested labels Aug 5, 2022
@reclaimingmytime
Copy link
Contributor

reclaimingmytime commented Aug 7, 2022

@Lord0fBytes

if you can get me the API_IDs

You can find them yourself by looking at the source code ;)

The show dropdown has an ID of Field7 and the options are the show names, so Coder Radio would be pre-selected using:
https://jblive.wufoo.com/embed/w7x2r7/def/Field7=Coder%20Radio

Having said that, I'm not sure if we're going to keep using Wufoo. Issue #232 is now part JB 1.0.

@Lord0fBytes
Copy link
Contributor

Awesome I appreciate that info. I'll make the change to it anyways because it's literally two lines of code.

If they go away from it no big deal.

@gerbrent gerbrent assigned Lord0fBytes and unassigned noblepayne Aug 8, 2022
@gerbrent gerbrent removed the JB - action needed action needed from a JB Team member label Aug 8, 2022
@elreydetoda
Copy link
Collaborator

I haven't been keeping up with all the PRs, @Lord0fBytes has there been any progress on this? (Just personally curious how the implementation will work)

@gerbrent
Copy link
Collaborator Author

@Lord0fBytes still wanna work on this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, enhancement, or request UX related to user experience
Projects
None yet
Development

No branches or pull requests

6 participants