Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump compat for GPUArraysCore to 0.2, (keep existing compat) #47

Merged
merged 4 commits into from
Nov 16, 2024

Conversation

fhagemann
Copy link
Contributor

I also exchanged using GPUArraysCore with import GPUArraysCore and added the prefix GPUArraysCore everywhere where it is used (which seems to be only in one line in transpose.jl).

@fhagemann
Copy link
Contributor Author

Failing Downgrade tests are due to FillArrays<0.13 not being supported in julia-1.11.
I also expect the tests to still run on [email protected] because StructArrays does not yet allow for [email protected].

@oschulz
Copy link
Member

oschulz commented Nov 15, 2024

Tests still run on GPUArraysCore v0.2, some deps will need to update first.

@fhagemann
Copy link
Contributor Author

fhagemann commented Nov 16, 2024

#45 set the lowest version of FillArrays to 0.13 (probably because of julia-1.11 compatibility).
It should be 0.13.8 though. We should either revert #45 back to FillArrays 0.8.4 (and run downgrade on julia-1.10) or increase the lower bound to 0.13.8. For this PR, I have chosen the latter.

@fhagemann fhagemann force-pushed the GPUArraysCore branch 2 times, most recently from 5dae62e to cfe4973 Compare November 16, 2024 14:27
@fhagemann
Copy link
Contributor Author

Basically, this PR does what #46 is proposing.
I would recommend to do both at once and make a patch release.

@oschulz
Copy link
Member

oschulz commented Nov 16, 2024

Test still use the old GPUArraysCore and StructArrays, looks like some deps need to update first.

@fhagemann
Copy link
Contributor Author

That's because of RadiationDetectorSignals.

@oschulz oschulz merged commit f09e3ab into JuliaPhysics:main Nov 16, 2024
9 checks passed
@fhagemann fhagemann deleted the GPUArraysCore branch November 16, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants