Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent dependency on ArnoldiMethod #354

Closed
gkantsidis opened this issue Mar 22, 2024 · 8 comments
Closed

Inconsistent dependency on ArnoldiMethod #354

gkantsidis opened this issue Mar 22, 2024 · 8 comments

Comments

@gkantsidis
Copy link

The Project.toml for the project in v.1.9 restricts ArnoldiMethod to v0.3 (ArnoldiMethod = "0.3"). However, in the official package repository (https://juliahub.com/ui/Packages/General/Graphs), the compatibility constraint is for v1.0 or v2.0 (ArnoldiMethod = "0.1, 0.2").
As a result, using the package still restricts ArnoldiMethod to v0.1 or v0.2.

It seems that the dependency has been updated but without updating this packages version number and without pushing the change to the official repo.

Would it be possible to fix this please?

@gkantsidis gkantsidis added the bug Something isn't working label Mar 22, 2024
@gkantsidis gkantsidis changed the title [BUG] Inconsistent dependency on ArnoldiMethod Inconsistent dependency on ArnoldiMethod Mar 22, 2024
@gdalle
Copy link
Member

gdalle commented Mar 22, 2024

The PR fixing it has been waiting for a review, if you review it I can merge and tag a release

#344

@gkantsidis
Copy link
Author

gkantsidis commented Mar 23, 2024

The current (from #344) version again seems to fix the version of ArnoldiMethod.jl (thanks!), but we will also need to increase the version number of this package (e.g. to 1.9.1) (otherwise, there will still be problems).

On the use of ArnolidMethod.jl:
The comments of the commit:
JuliaLinearAlgebra/ArnoldiMethod.jl@5622150
seems to suggest (to me) that the authors would like to discourage the use of LR(), LM() and the like, and encourage the use of :LR, :LM, etc.
I have created a pull request in #355 that attempts to fix that.

@gdalle
Copy link
Member

gdalle commented Mar 23, 2024

Yeah I know we need to tag a new release, I'm just waiting to merge one or two more PRs first. This will happen next week at the latest

@simonschoelly simonschoelly removed the bug Something isn't working label Mar 23, 2024
@simonschoelly
Copy link
Member

Do you need a new release urgently? Otherwise you also specify that you want use add Graphs#master to use the latest master branch - there is probably also a way to specify a commit hash - but I did not find the doc on that atm.

@gkantsidis
Copy link
Author

Thanks. I do need a new release (an internal project has a direct dependency on ArnoldiMethod.jl, and a transitive dependency on Graphs -- so, it does not seem possible to just add Graphs#master). However, we can wait a few days for @gdalle to create the new release.
Thanks to both!

@gdalle
Copy link
Member

gdalle commented Mar 23, 2024

@simonschoelly there's no problem with releasing often, right? Since we have adopted ColPrac, the standard could even be to release after each PR

@thchr
Copy link
Contributor

thchr commented Apr 12, 2024

This is resolved with the package registration from last week, right?

@gdalle
Copy link
Member

gdalle commented Apr 12, 2024

Yes indeed, let's close

@gdalle gdalle closed this as completed Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants