Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify non_backtracking_matrix function's Return Type #328

Merged
merged 6 commits into from
May 4, 2024
Merged

Modify non_backtracking_matrix function's Return Type #328

merged 6 commits into from
May 4, 2024

Conversation

KeishiS
Copy link
Contributor

@KeishiS KeishiS commented Jan 17, 2024

As mentioned in #326, I modified non_backtracking_matrix so that it returns a spase matrix.

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.28%. Comparing base (5878e7b) to head (d4206ae).
Report is 26 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #328      +/-   ##
==========================================
- Coverage   97.30%   97.28%   -0.03%     
==========================================
  Files         115      118       +3     
  Lines        6796     6880      +84     
==========================================
+ Hits         6613     6693      +80     
- Misses        183      187       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@gdalle gdalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! I made a few remarks but once these are addressed we can merge

src/linalg/nonbacktracking.jl Outdated Show resolved Hide resolved
src/linalg/nonbacktracking.jl Show resolved Hide resolved
@KeishiS KeishiS requested a review from gdalle January 26, 2024 03:51
Copy link
Member

@gdalle gdalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor efficiency considerations, otherwise I think this will be good to go

src/linalg/nonbacktracking.jl Outdated Show resolved Hide resolved
src/linalg/nonbacktracking.jl Outdated Show resolved Hide resolved
@gdalle gdalle added the enhancement New feature or request label Jan 29, 2024
@gdalle
Copy link
Member

gdalle commented Mar 5, 2024

Hi @KeishiS just checking in to see if you want to take care of the last changes or if I should?

@KeishiS
Copy link
Contributor Author

KeishiS commented Mar 5, 2024

I will commit the revised version within this week. Sorry for the delay.

@gdalle
Copy link
Member

gdalle commented Mar 5, 2024

No worries, thanks!

src/linalg/nonbacktracking.jl Outdated Show resolved Hide resolved
src/linalg/nonbacktracking.jl Outdated Show resolved Hide resolved
Copy link
Member

@gdalle gdalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost there, just a few things to tweak in the tests

test/linalg/nonbacktracking.jl Outdated Show resolved Hide resolved
test/linalg/nonbacktracking.jl Outdated Show resolved Hide resolved
@gdalle gdalle linked an issue May 4, 2024 that may be closed by this pull request
@gdalle gdalle merged commit 5415516 into JuliaGraphs:master May 4, 2024
8 of 12 checks passed
@KeishiS KeishiS deleted the modify-non_backtracking branch May 8, 2024 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question regarding non_backtracking_matrix function's return type
2 participants