-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify non_backtracking_matrix
function's Return Type
#328
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #328 +/- ##
==========================================
- Coverage 97.30% 97.28% -0.03%
==========================================
Files 115 118 +3
Lines 6796 6880 +84
==========================================
+ Hits 6613 6693 +80
- Misses 183 187 +4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! I made a few remarks but once these are addressed we can merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor efficiency considerations, otherwise I think this will be good to go
Hi @KeishiS just checking in to see if you want to take care of the last changes or if I should? |
I will commit the revised version within this week. Sorry for the delay. |
No worries, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
almost there, just a few things to tweak in the tests
As mentioned in #326, I modified
non_backtracking_matrix
so that it returns a spase matrix.