Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to GPUArrays.jl transition to KernelAbstractions.jl. #260

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Oct 17, 2024

No description provided.

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.04%. Comparing base (4a24e61) to head (358fcf5).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #260      +/-   ##
==========================================
+ Coverage   78.55%   80.04%   +1.49%     
==========================================
  Files           9        9              
  Lines         457      436      -21     
==========================================
- Hits          359      349      -10     
+ Misses         98       87      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maleadt
Copy link
Member Author

maleadt commented Oct 17, 2024

Looks like Clang's Darwin driver doesn't recognize our custom linker path points to lld, so we'll need to set the flavor using -fuse-ld. Not sure how to best pipe that through PoCL, it's becoming a mess of env vars...

@maleadt
Copy link
Member Author

maleadt commented Oct 17, 2024

CI failure unrelated.

@maleadt maleadt merged commit a3ca010 into master Oct 17, 2024
4 of 5 checks passed
@maleadt maleadt deleted the tb/gpuarrays_kernelabstractions branch October 17, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant