Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add push notifications #452

Merged
merged 13 commits into from
Jul 30, 2021
Merged

Feat/add push notifications #452

merged 13 commits into from
Jul 30, 2021

Conversation

Jozwiaczek
Copy link
Owner

@Jozwiaczek Jozwiaczek commented Jul 17, 2021

Overview of PR

Add web push notifications functionality in the client as well as in api packages.

All use cases for push notifications (eg. sending notifications when someone joined the system) will be implemented in others pull requests.

How to test

If You would like to test this, follow these steps:

  • install deps with yarn
  • add test endpoint in push-notifications.controller.ts:
  @Get()
  async send(): Promise<void> {
    await this.pushNotificationsService.send({ title: 'test title', body: 'test body' });
  }
  • generate VAPID keys
  • add generated private and public keys in api package env file
  • add public key in client package env file
  • run server with yarn start api package script
  • run client with serve:build client script (it requires to be run in production mode)

@cypress
Copy link

cypress bot commented Jul 17, 2021



Test summary

9 0 0 0


Run details

Project e2e
Status Passed
Commit b7bf49e ℹ️
Started Jul 30, 2021 11:47 PM
Ended Jul 30, 2021 11:47 PM
Duration 00:36 💡
OS Linux Debian - 10.5
Browser Electron 89

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@Jozwiaczek Jozwiaczek requested a review from Mefjus July 18, 2021 22:30
@Jozwiaczek Jozwiaczek added api Changes related with 'api' package client Changes related with 'client' package labels Jul 18, 2021
@Jozwiaczek Jozwiaczek linked an issue Jul 18, 2021 that may be closed by this pull request
@Jozwiaczek Jozwiaczek self-assigned this Jul 18, 2021
@Jozwiaczek Jozwiaczek requested a review from Vatras July 20, 2021 08:05
@Jozwiaczek Jozwiaczek merged commit 4fa9bbf into dev Jul 30, 2021
@Jozwiaczek Jozwiaczek deleted the feat/add-push-notifications branch July 30, 2021 23:48
@Jozwiaczek
Copy link
Owner Author

🎉 This PR is included in version 1.11.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Changes related with 'api' package client Changes related with 'client' package released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle push notification
3 participants