Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API / QT-GUI feature request] option to not broadcast the transaction after signing #1011

Open
openoms opened this issue Sep 8, 2021 · 5 comments

Comments

@openoms
Copy link
Contributor

openoms commented Sep 8, 2021

To fund an LN channel from JoinMarket there is a need to not broadcast the transaction after signing - it needs to be passed to the LN client instead.
This is usually done with a simple copy-paste to the terminal

It is counter-intuitive in the QT as one needs to choose to "not accept" the transaction and scroll up for the HEX output to be copied.
(related issue to improve the fee handling of direct sends #1009)

To support this usecase better there could be an option to choose to not broadcast transaction on the Coinjoins tab which could be the equivalent of the --psbt flag of the sendpayment.py.

--psbt           output as psbt instead of broadcasting the transaction. 
                 Currently only works with direct send (-N 0).
@kristapsk
Copy link
Member

Related - #414.

@kristapsk
Copy link
Member

Another idea I have is more customizable transaction broadcast methods, would be useful with stuff like https://github.com/sgeisler/btcbc-rs. The "not broadcast" then could be configured as just echo.

@AdamISZ
Copy link
Member

AdamISZ commented Jun 1, 2022

To support this usecase better there could be an option to choose to not broadcast transaction on the Coinjoins tab which could be the equivalent of the --psbt flag of the sendpayment.py.

Agreed, at least for command line, and at least for a single join schedule, it should be eminently possible to support this. I'll mark it help wanted for now; I don't plan to do it but I'm happy to help out anyone who wants to give it a shot.

Edit: I just noticed you specified Qt explicitly. It'll be harder there as we saw in #414 so maybe just command line at first? I tend to think we will drift away from Qt to RPC-API mostly.

@openoms
Copy link
Contributor Author

openoms commented Oct 1, 2022

Sending a transaction in the CLI without coinjoin (direct send) there is already a question if want to broadcast.
in the case when want to send to a lightning channel the answer is no as would need to broadcast through the lightning client.

The same is also needed in the API.
Currently https://joinmarket-org.github.io/joinmarket-clientserver/api/#operation/directsend does both create and broadcast in a single step.
To be able use the JoinMarket wallet through the API (in Jam) as the external funder for a lightning channel the transaction creation and broadcast need to be separated into two calls.

@openoms openoms changed the title [QT-GUI improvement] option to not broadcast the transaction after signing [API / QT-GUI feature request] option to not broadcast the transaction after signing Oct 1, 2022
@kristapsk
Copy link
Member

romanz/electrs#1056

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants