-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[API / QT-GUI feature request] option to not broadcast the transaction after signing #1011
Comments
Related - #414. |
Another idea I have is more customizable transaction broadcast methods, would be useful with stuff like https://github.com/sgeisler/btcbc-rs. The "not broadcast" then could be configured as just |
Agreed, at least for command line, and at least for a single join schedule, it should be eminently possible to support this. I'll mark it help wanted for now; I don't plan to do it but I'm happy to help out anyone who wants to give it a shot. Edit: I just noticed you specified Qt explicitly. It'll be harder there as we saw in #414 so maybe just command line at first? I tend to think we will drift away from Qt to RPC-API mostly. |
Sending a transaction in the CLI without coinjoin (direct send) there is already a question if want to broadcast. The same is also needed in the API. |
To fund an LN channel from JoinMarket there is a need to not broadcast the transaction after signing - it needs to be passed to the LN client instead.
This is usually done with a simple copy-paste to the terminal
bos open
is used most often - https://github.com/alexbosworth/balanceofsatoshisfundchannel_start id amount
- https://lightning.readthedocs.io/lightning-fundchannel_start.7.htmland
fundchannel_complete id psbt
- https://lightning.readthedocs.io/lightning-fundchannel_complete.7.htmlIt is counter-intuitive in the QT as one needs to choose to "not accept" the transaction and scroll up for the HEX output to be copied.
(related issue to improve the fee handling of direct sends #1009)
To support this usecase better there could be an option to choose to not broadcast transaction on the
Coinjoins
tab which could be the equivalent of the--psbt
flag of thesendpayment.py
.The text was updated successfully, but these errors were encountered: