Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinstalling toolchains with rustup does not preserve components/targets #45

Open
ajungren opened this issue Sep 30, 2019 · 0 comments
Open

Comments

@ajungren
Copy link

When rustup install attempts to update a toolchain but fails, the toolchain is uninstalled and reinstalled. The issue is that none of the components or targets are reinstalled after the toolchain is. Not reinstalling the same targets isn't ideal but as long as every build uses the cargo runner in TeamCity the target will be added on the next build, test, etc. Not reinstalling the components, however, requires manual intervention if rustfmt (also cargo fmt) and/or clippy (also cargo clippy) are used because these aren't supported by this plugin (#44) so they won't be reinstalled.

Ideally, reinstalling the toolchain would be optional and fail the build if the toolchain couldn't be updated and reinstallation is disabled, but reinstalling the components that were previously installed would at least stop it from breaking builds until they're manually reinstalled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant