Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Designer - SMDesignerElement: background image has position:fixed #107

Open
Jemt opened this issue May 16, 2019 · 0 comments
Open

Designer - SMDesignerElement: background image has position:fixed #107

Jemt opened this issue May 16, 2019 · 0 comments

Comments

@Jemt
Copy link
Owner

Jemt commented May 16, 2019

The designer supports custom "designable" elements which allows the user to select a background image. But the image has background-attachment:fixed which means the image position is fixed to the viewport rather than the container in which it is being used. And while it gives us a very cool effect when scrolling, this is not always the desirable behaviour. Allow user to choose positioning behaviour: fixed (background-attachment:fixed set) or static (background-attachment not set).

Notice how image position is the same when scrolling, giving us the impression that the container is a "window" (transparent layer) allowing us to peak at the wallpaper behind the website.

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant