Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rotors] bugfixes for rotors sim and frontend changes #180

Closed
wants to merge 14 commits into from

Conversation

RUFFY-369
Copy link
Contributor

Bugfixes and frontend changes

@RUFFY-369 RUFFY-369 changed the title Rotors bugfix [rotors] bugfixes and frontend changes Sep 12, 2022
@RUFFY-369 RUFFY-369 changed the title [rotors] bugfixes and frontend changes [rotors] bugfixes for rotors sim and frontend changes Sep 12, 2022
@pariaspe pariaspe self-requested a review September 18, 2022 12:36
@pariaspe pariaspe linked an issue Sep 18, 2022 that may be closed by this pull request
@RUFFY-369
Copy link
Contributor Author

@pariaspe , @iamarkaj

Copy link
Collaborator

@pariaspe pariaspe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments:

  • Why changing car beacon on visual landing exercise?
  • Is it possible to change QRs with aruco markers in the packages?
  • Aruco vs apriltag?
  • Aruco on turtlebot?

PS: Review of python files is still missing..

@RUFFY-369
Copy link
Contributor Author

  • Not a strategic choice but just thought that the drone will look good landing on moving landing pad
  • It's possible to change by changing the texture file of QR to Aruco. But right now the QRs are used for getting the coordinates of the target in package_delivery and Aruco is used for localisation or landmarking. I don't know if changing QR to Aruco will be beneficial for getting coordinates. And QR basically just simulates how it's done in real life with drone package delivery.
  • Not much of a difference as both are used in landmarking system but Apriltag works well for long range detection i.e., more height of the drone
  • It can be done by changing the texture file but again both performs same role but Apriltag works well for long range

@pariaspe
Copy link
Collaborator

Hi @RUFFY-369 , sorry for the late response

  • Not a strategic choice but just thought that the drone will look good landing on moving landing pad

Not sure about this, the previous one is easier to detect, even when you are close to the car.

  • It's possible to change by changing the texture file of QR to Aruco. But right now the QRs are used for getting the coordinates of the target in package_delivery and Aruco is used for localisation or landmarking. I don't know if changing QR to Aruco will be beneficial for getting coordinates. And QR basically just simulates how it's done in real life with drone package delivery.

The good thing about Aruco markers is that they are included in opencv. How are you planning to read QRs?

  • Not much of a difference as both are used in landmarking system but Apriltag works well for long range detection i.e., more height of the drone

As I said above, I normally use/prefer Aruco due to its opencv integration.

  • It can be done by changing the texture file but again both performs same role but Apriltag works well for long range

Same.

@pariaspe
Copy link
Collaborator

pr split up in #183, #184, #185

@pariaspe pariaspe closed this Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[rotors] bugfixes and frontend changes
2 participants