Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refinements on the "Execution" subwindow #221

Open
4 of 6 tasks
jmplaza opened this issue Aug 26, 2023 · 3 comments
Open
4 of 6 tasks

Refinements on the "Execution" subwindow #221

jmplaza opened this issue Aug 26, 2023 · 3 comments
Assignees

Comments

@jmplaza
Copy link
Member

jmplaza commented Aug 26, 2023

The first prototype of Execution subwindow is ready. Good job @siddheshsingh26 !

Let's improve it further:

  • remove the editor subwindow in the VC+
  • remove the file directory viewer subwindow in the VC+
  • rename VC+ as "EXECUTION" and replace the orange with the dark grey color of the top bar of VisualCircuit.
  • remove the JdeRobot logo at the RUN part of the webpage, the layout button, the choose file button, and the "User 1 - Project B" message at the top bar. The choose file is not needed anymore as the "file" to load is the zip file generated by the VisualCircuit backend, and there is no "user" or "project name" to show (those were things useful at the PythonWebIDE, but not here)
  • Connect the "Play" button with (a) launching the internal translation, (b) the generation of the zip file, (b) the loading of that zip file and finally (d) its execution. Maybe a message should be shown to the user for telling her/him which stage the process is.
  • Introduce a mobile vertical separator between the "editor side" of the webpage and the "execution side" of the webpage. Maybe you could reuse the code of the vertical separators already included in the current "run side" to separate subwindows
@BkPankaj
Copy link
Collaborator

Hello @jmplaza , @siddheshsingh26 ,
Could you kindly confirm the current status of this issue? If it's still open, could you please indicate which tasks are remaining based on the above description? However, I've noticed that a vertical separator has been implemented between the editor and execution sides in VC+ but mentioned unsolved(last task). Also, the JdeRobot logo in the RUN section and the browse button appear to be unresolved, despite being marked as completed earlier (4th task). Additionally, the top bar continues to display an orange color (3rd task).

This is how VC+ looks on my machine.

Any assistance with these remaining tasks would be appreciated.

@jmplaza
Copy link
Member Author

jmplaza commented Jan 30, 2024

HI @BkPankaj,

yes, it is open. We are waiting a little bit for the ongoing RoboticsApplicationManager (RAM, repo) refactoring to be finished. The dockerized execution of robotics applications, even those generated with VisualCircuit, heavily relies on it, and we are improving it.

Feel free to face other issues meanwhile. Developing new applications with VisualCircuit to be run locally is also a very good way of contributing.

@BkPankaj
Copy link
Collaborator

Thank you for the update, @jmplaza ! It's great to hear about the ongoing refactoring of the Robotics Application Manager repository, and I'm looking forward to contributing there as well. I understand the importance of this work, especially in relation to the dockerized execution of applications generated with VisualCircuit. I'll focus on addressing other issues and contributing in different ways. I'm also excited about the prospect of developing new applications with VisualCircuit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants