Skip to content

Latest commit

 

History

History
50 lines (36 loc) · 3.17 KB

README.md

File metadata and controls

50 lines (36 loc) · 3.17 KB
Raw

sencha-hotfixes

Provides a jarvus-hotfixes package for each ExtJS / Sencha Touch version containing all hotfixes managed by Jarvus Innovations. These packages strictly contains only overrides that restore framework components to their intended/documented behavior, and do not add features or opinionate framework usage. Our intention is that these packages be safe to include in every project from the start to save developers from going down framework bug rabbit-holes that have already been gone down.

Hotfix requirements

  • Restores indended or documented behavior of the framework -- no new features
  • Contains a link to both a forum post about the issue and a fiddle for reproducing/testing the issue
  • If copying a function body from the framework is necessary, there should be separate commits documenting the copying of the as-is function into the hotfix and for each change then made to that function body

Supported frameworks

Hotfix packages are currently being maintained for:

Using hotfixes

This repository has separate branches for each framework+version, with the master branch serving as a template for new branches.

Step 1) Clone a branch into your packages folder

Open a terminal in your app's or workspace's packages directory and clone the branch for the framework+version you're using into a directory called jarvus-hotfixes:

git clone -b touch/2/4/1/527 https://github.com/JarvusInnovations/sencha-hotfixes.git jarvus-hotfixes

Step 2) Add package to app's requirements

Open the app.json file in your app's directory and add "jarvus-hotfixes" to the array following the existing "requires" attribute:

    "requires": [
        "jarvus-hotfixes"
    ],

Step 3) Refresh bootstrap.js

In order for the overrides contained in the package to be automatically loaded by our app, the bootstrap.js file generated by Sencha CMD must be updated after adding a new package to the app's "requires" config. Run this from your app's directory:

sencha app refresh

Pull requests

Pull requests containing new or improved hotfixes are welcome! We will test and review them before incorporating into our hotfix packages