Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(jans-cedarling): consolidate JwtService initialization logic into the module #9945

Open
rmarinn opened this issue Oct 26, 2024 · 0 comments · May be fixed by #9980
Open

refactor(jans-cedarling): consolidate JwtService initialization logic into the module #9945

rmarinn opened this issue Oct 26, 2024 · 0 comments · May be fixed by #9980
Assignees
Labels
comp-jans-cedarling Touching folder /jans-cedarling enhancement kind-enhancement Issue or PR is an enhancement to an existing functionality

Comments

@rmarinn
Copy link
Contributor

rmarinn commented Oct 26, 2024

Is your feature request related to a problem? Please describe.

In #9870, the initialization logic for JwtService was moved outside its module, resulting in a less modular and more tangled initialization process. This not only makes JwtService harder to maintain, but also introduces coupling between multiple modules. Whenever the constructor for JwtService changes, those changes cascade across the init and common modules, causing unintended dependencies and increasing the complexity of modifications.

Describe the solution you'd like

  • The JwtService initialization logic should reside entirely within its own module. This ensures that other modules are not responsible for managing how JwtService is set up, reducing unnecessary coupling.
  • To achieve this, an interface will be implemented for JwtService that other modules can rely on for interaction. This interface will abstract the initialization details, promoting decoupling. This means other modules will be insulated from changes in JwtService's constructor or internal setup, allowing for easier modifications and better separation of concerns.
@rmarinn rmarinn added comp-jans-cedarling Touching folder /jans-cedarling enhancement labels Oct 26, 2024
@rmarinn rmarinn assigned moabu and rmarinn and unassigned moabu Oct 26, 2024
@mo-auto mo-auto added the kind-enhancement Issue or PR is an enhancement to an existing functionality label Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-jans-cedarling Touching folder /jans-cedarling enhancement kind-enhancement Issue or PR is an enhancement to an existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants