-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression with Nix 2.24.8/NixOS 24.11. #8
Comments
This commit a) fixes issue Janik-Haag#8, and b) wraps the `nix-instantiate` call in a Python `with` block, which is easier to read than using `procfs`. It also means the `nix-instantiate` call is portable. Signed-off-by: Dom Rodriguez <[email protected]>
urgh, I honestly don't want to deal with bugs introduced by upstream CppNix, the easiest solution here is to just switch to lix. It's a lot faster, has a better ux and fewer bugs, so changing to lix is worth it anyway. Lix is a fork of CppNix and drop-in replacement for 99.5% of nix use cases. |
I actually fixed the bug in my fork. I’ll make a PR shortly. I personally am happy with Nix.
EDIT: Combining comments.
I am not sure it is Nix - but the issue arose from the procfs parameter. I've fixed it to read from a 'NamedTemporaryFile' and wrapped in a 'with' block. The temporary file is deleted upon exit.
With regards to changing to Lix, I think, to avoid breaking this tool for existing users (given it's documented in a Nixpkgs option), I would like to request that the move to Lix is done in a different repo.
…________________________________
|
Thank you, I'll try reviewing it in a bit.
I'm quite certain it's only newer Nix versions, the issue doesn't occur with Lix nor with older Nix versions. |
Hi,
I've been using your tool, but there appears to be a regression in Nix 2.24.8/NixOS 24.11.
I've attached logs below of the output I'm getting.
I'm not sure what the exact cause is yet, but maybe you might know.
Thanks! :)
nm2nix-error.txt
nm2nix--nix-info.txt
The text was updated successfully, but these errors were encountered: