Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace $timeout by $interval to allow tests with protractor #81

Closed
gregwym opened this issue Mar 19, 2015 · 3 comments
Closed

Replace $timeout by $interval to allow tests with protractor #81

gregwym opened this issue Mar 19, 2015 · 3 comments

Comments

@gregwym
Copy link

gregwym commented Mar 19, 2015

Protractor wait for $timeout to finish before start testing. Growl ttl should use $interval instead, to enable protractor to validate the notification message.

marcorinck#43
angular/protractor#169
@k3v3n
Copy link

k3v3n commented Apr 9, 2015

Any plan to fix this ?

@silbermm
Copy link

👍

gastonelhordoy added a commit to gastonelhordoy/angular-growl-2 that referenced this issue Apr 27, 2015
@gastonelhordoy
Fixes JanStevens#81 replacing by and making notifications being testa…
104786c 
…ble by protractor
@area
Copy link

area commented Jun 25, 2015

This seems like a pretty obvious thing to do. Is there a reason you're hesitant, @JanStevens?

EDIT: I somehow missed the pending pull request, and you're waiting on tests to be included.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@k3v3n @silbermm @area @gregwym