-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide Tab bar if there is only a single library open #9971
Comments
I am against this proposal. |
Yes there might be some advantages of this visualization. However, (1) the name of the library is also in the Window title, (2) the context menu items could also be accessed via the main menu > Library. |
hmmm. I mean ... having more vertical space would indeed really be nice for devices with low screen space like laptops or notebooks ... But not all configuration options are accessible via Following important feature will be lost: "Reveal in file explorer" So as precondition to implement this feature, i would suggest to:
Then I would agree with your proposal, unless there is severe performance loss. |
Devcall discussionPro:
Contra:
Decision:Add preferences option to hide the bar if only one tab is open and make it default on |
/assign-me |
LibraryTab probably |
I mean the component which contains the names of the libraries. |
StateManager: jabref/src/main/java/org/jabref/gui/StateManager.java Lines 90 to 92 in b701821
|
Please assign this issue to me. |
👋 Hey @priyanshu16095, it looks like you're interested in working on this issue! 🎉 If you'd like to take on this issue, please use the command |
/assign-me |
👋 Hey @priyanshu16095, thank you for your interest in this issue! 🎉 We're excited to have you on board. Start by exploring our Contributing guidelines, and don't forget to check out our workspace setup guidelines to get started smoothly. In case you encounter failing tests during development, please check our developer FAQs! Having any questions or issues? Feel free to ask here on GitHub. Need help setting up your local workspace? Join the conversation on JabRef's Gitter chat. And don't hesitate to open a (draft) pull request early on to show the direction it is heading towards. This way, you will receive valuable feedback. Happy coding! 🚀 ⏳ Please note, you will be automatically unassigned if the issue isn't closed within 90 days (by 16 April 2025). A maintainer can also add the "📌 Pinned"" label to prevent automatic unassignment. |
For knowing the number of open libraries, should I create a function in the state manager? I can't find it in any other class or the state manager. |
Neither of the approaches works because they do not update the value of openDatabases in real time, so I am using a ListChangeListener. |
I think you can try to use Bindings.size(stateManager.getOpenDatabases()) as well for this https://docs.oracle.com/javase/8/javafx/api/javafx/beans/binding/Bindings.html#size-javafx.collections.ObservableList- |
Using Bindings.size(stateManager.getOpenDatabases()) is also not working fine. Could you please suggest what else I can do? |
Cosmetic improvement:
In order to free more vertical space, I'd suggest to hide the Tab bar if there is only a single open Library (which I believe is a typical situation for most users).
The text was updated successfully, but these errors were encountered: