You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
we don't define the expected type for remove_conditions (which downstream appears to be Union[None, Condition, Iterable[Condition], Conjunction]). And we type ktk_cube_dataset_ids as Optional[Iterable[str]] but we don't set any default value (which apparently should be "all").
Also, it's not really clear what a " Ktk_cube dataset IDs " means. Is this the same thing as a kartothek dataset UUID ?
This is just a single example. I think there's room for improvement here without the need for major breaking changes.
The text was updated successfully, but these errors were encountered:
Problem description
Currently the expected input for cube functions is not very clear, as a first-time user.
For example, for the function
kartothek/kartothek/io/dask/bag_cube.py
Line 451 in 4008de4
remove_conditions
(which downstream appears to beUnion[None, Condition, Iterable[Condition], Conjunction]
). And we typektk_cube_dataset_ids
asOptional[Iterable[str]]
but we don't set any default value (which apparently should be"all"
).Also, it's not really clear what a " Ktk_cube dataset IDs " means. Is this the same thing as a kartothek dataset UUID ?
This is just a single example. I think there's room for improvement here without the need for major breaking changes.
The text was updated successfully, but these errors were encountered: