Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate client names #205

Open
Razish opened this issue May 6, 2013 · 4 comments
Open

Duplicate client names #205

Razish opened this issue May 6, 2013 · 4 comments

Comments

@Razish
Copy link
Member

Razish commented May 6, 2013

Clients should not be able to use the same name. Appending their clientnum is recommended - also disallow imitating an appended clientnum if it is not their own.

Consider this, Bob and yourself (Dave) in a server:

 Bob renamed to Test
]/name Test
 Dave renamed to Test [2]
]/name Dave
 Test [2] renamed to Dave
]/name Test [1]
 Dave renamed to Test [2]
@eezstreet
Copy link
Contributor

MB2 has this (as does lmd)

Sent from my Windows Phone


From: Razishmailto:[email protected]
Sent: ‎5/‎6/‎2013 8:32 AM
To: Razish/OpenJKmailto:[email protected]
Subject: [OpenJK] Duplicate client names (#205)

Clients should not be able to use the same name. Appending or prepending their clientnum is recommended - also disallow imitating a prepended clientnum if it is not their own.

Consider this, Bob and yourself (Dave) in a server:

 Bob renamed to Test
]/name Test
 Dave renamed to Test [2]
]/name Dave
 Test [2] renamed to Dave
]/name Test [1]
 Dave renamed to Test [2]

Reply to this email directly or view it on GitHub:
#205

@ensiform
Copy link
Member

ensiform commented May 6, 2013

Q3F/ETF just appends a number count of times the name is being duplicated.

ie: Padawan, Padawan_1, Padawan_2

@Yberion
Copy link
Contributor

Yberion commented May 6, 2013

Ida gamall's security fix have this too, well i think it's a good idea.

@ensiform
Copy link
Member

ensiform commented May 6, 2013

Yea well lets avoid his crap please.

@ensiform ensiform added the Mod label Aug 20, 2014
TriForceX pushed a commit to TriForceX/OpenJK that referenced this issue Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants