Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Currency textfield in add exchange rate doesn't match the design system #3619

Open
1 task done
p42rthicle opened this issue Oct 14, 2024 · 7 comments
Open
1 task done
Assignees
Labels
approved Approved by the Ivy Wallet team. Ready for dev bug Something isn't working P3 Insignificant. Very low priority

Comments

@p42rthicle
Copy link
Contributor

Please confirm the following

Describe the bug

The currency textfield in the manual adding exchange rates modal dialog doesn't match the design system and isn't like other textfields in the app.

To Reproduce

  1. Try adding a manual exchange rate
  2. Notice the currency textfield design

Expected behavior

Should match the rest of the app

Screenshots

exchange_rate_textfield

App version

v2024.10.13 (202)

Smartphone

Samsung Galaxy S23

Additional context

No response

@p42rthicle p42rthicle added the bug Something isn't working label Oct 14, 2024
@ivywallet
Copy link
Collaborator

Thank you @p42rthicle for raising Issue #3619! 🚀
What's next? Read our Contribution Guidelines 📚.

Tagging @ILIYANGERMANOV for review & approval 👀

@ILIYANGERMANOV ILIYANGERMANOV added approved Approved by the Ivy Wallet team. Ready for dev P3 Insignificant. Very low priority labels Oct 14, 2024
@mahmoodharis88
Copy link
Contributor

I'm on it

@ivywallet
Copy link
Collaborator

Thank you for your interest @mahmoodharis88! 🎉
Issue #3619 is assigned to you. You can work on it! ✅

If you don't want to work on it now, please un-assign yourself so other contributors can take it.

Also, make sure to read our Contribution Guidelines.

@mahmoodharis88
Copy link
Contributor

@p42rthicle can you please share text field design that need to place here?

@mahmoodharis88
Copy link
Contributor

Add Rate Screen

@p42rthicle
Copy link
Contributor Author

@mahmoodharis88 This text size is too big, see for a place that using smaller sized text field in the app you should be able to find it. I dont have the exact design. You can look at what the text size was before and then use a component accordingly

@mahmoodharis88
Copy link
Contributor

@p42rthicle
add rate screen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved by the Ivy Wallet team. Ready for dev bug Something isn't working P3 Insignificant. Very low priority
Projects
None yet
Development

No branches or pull requests

4 participants