Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responsive icons or ability to reverse the icons #8

Open
louis-l opened this issue Jan 19, 2020 · 2 comments
Open

Responsive icons or ability to reverse the icons #8

louis-l opened this issue Jan 19, 2020 · 2 comments

Comments

@louis-l
Copy link

louis-l commented Jan 19, 2020

Hello,

First of all, thank you for the awesome component.

While I was playing around with it, I realized that this is not responsive on smaller devices. I found this issue #4 and its still under "help wanted".

I tried some hacks:

  • use css transform to scale the container (example: transform: scale(0.75); transform-origin: top left;) but the overal layout did not look good. There is a gap below the icons due to the scale css
  • make the container scrollable but there is another issue here because now users can only see the first few negative feedback icons and they think they can only select from "Very Poor", "Poor" or "Average".

So if we can have the responsive icons, that is perfect.
If not, how about the ability to reverse the icons?

Thanks,
Louis

@guastallaigor
Copy link
Contributor

Hi, I can try to help you.
Can you share an example of your use case?
In the project I was using it, with the height/width props it worked on smaller devices for me.
I know it's a bit of a hack, but it can work.

@louis-l
Copy link
Author

louis-l commented Feb 21, 2020

Thanks @guastallaigor

My use case is simple, try to make it responsive in different screen sizes.
I did not end up with implementing anything. Coz most of our users are using desktop, so dont think its worth the effort for us to fix little thing.

But Im still intertested in you solution to see how you solve the problem.

Cheers,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants