Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration option for device frame_id or a tf prefix #380

Open
meyerj opened this issue Nov 14, 2017 · 0 comments
Open

Add configuration option for device frame_id or a tf prefix #380

meyerj opened this issue Nov 14, 2017 · 0 comments

Comments

@meyerj
Copy link
Contributor

meyerj commented Nov 14, 2017

The device frame_id used for tf should be configurable via a ROS parameter, in the same way as tango/area_description_frame_id and tango/start_of_service_frame_id. If the Tango device is part of a bigger tree, the device pose is typically part of the robot description and published by something like robot_state_publisher.

As a workaround you could introduce additional static transforms that identify the two frames, but in general just "device" is a bit unspecific in a wider scope and should be configurable.

An alternative solution that also applies to all other frames attached to device would be to prefix the frame ids with the value of the tango/tf_prefix parameter, if set. While tf_prefix support has been removed as a core feature of tf2 (see tf2 migration guide), it can still be applied and useful for user code and many nodes have such a parameter. ros::names::resolve(namespace, name, remap) can help with that, even though it is not meant for tf frame ids.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant