Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API documentation for tensor C API #1130

Open
diptorupd opened this issue Mar 19, 2023 · 1 comment
Open

API documentation for tensor C API #1130

diptorupd opened this issue Mar 19, 2023 · 1 comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@diptorupd
Copy link
Contributor

The C API for dpctl and dpctl.tensor.usm_ndarray currently is auto-generated using Cython. A problem with using Cython to auto-generate the headers is the complete lack of API documentation.

For dpctl, it is perhaps not that important as the C API is a wrapper around libsyclinterface and sycl and the users for the C API for the dpctl classes might always be rather limited (e.g. numba-dpex/dpnp).

I feel dpctl.tensor.usm_ndarray is more important from the perspective of integration with other native extensions. Therefore, we should have a documented API for the C interface of dpctl.tensor.usm_ndarray.

Given the limitations of Cython, what other alternatives do we have?

@diptorupd diptorupd added documentation Improvements or additions to documentation enhancement New feature or request labels Mar 19, 2023
@oleksandr-pavlyk
Copy link
Collaborator

Cython-generated C-API is document here: https://intelpython.github.io/dpctl/latest/api_reference/dpctl_capi.html

The documentation page is hand generated though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants