diff --git a/dpctl/tensor/libtensor/include/kernels/reductions.hpp b/dpctl/tensor/libtensor/include/kernels/reductions.hpp index 36aad581a6..f3754e8820 100644 --- a/dpctl/tensor/libtensor/include/kernels/reductions.hpp +++ b/dpctl/tensor/libtensor/include/kernels/reductions.hpp @@ -2247,11 +2247,10 @@ template struct TypePairSupportDataForCompReductionAtomic { - /* value if true a kernel for must be instantiated, false + /* value is true if a kernel for must be instantiated, false * otherwise */ - static constexpr bool is_defined = std::disjunction< // disjunction is C++17 - // feature, supported - // by DPC++ + // disjunction is C++17 feature, supported by DPC++ + static constexpr bool is_defined = std::disjunction< // input int32 td_ns::TypePairDefinedEntry, // input uint32 @@ -2260,6 +2259,10 @@ struct TypePairSupportDataForCompReductionAtomic td_ns::TypePairDefinedEntry, // input uint64 td_ns::TypePairDefinedEntry, + // input float + td_ns::TypePairDefinedEntry, + // input double + td_ns::TypePairDefinedEntry, // fall-through td_ns::NotDefinedEntry>::is_defined; }; @@ -2268,19 +2271,17 @@ template struct TypePairSupportDataForCompReductionTemps { - static constexpr bool is_defined = std::disjunction< // disjunction is C++17 - // feature, supported - // by DPC++ input bool + // disjunction is C++17 feature, supported by DPC++ + static constexpr bool is_defined = std::disjunction< + // input bool td_ns::TypePairDefinedEntry, // input int8_t td_ns::TypePairDefinedEntry, - // input uint8_t td_ns::TypePairDefinedEntry, // input int16_t td_ns::TypePairDefinedEntry, - // input uint16_t td_ns::TypePairDefinedEntry,