Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional Tests for Batch Descriptor Inserts #214

Open
ifadams opened this issue Sep 10, 2024 · 1 comment
Open

Additional Tests for Batch Descriptor Inserts #214

ifadams opened this issue Sep 10, 2024 · 1 comment
Labels
Enhancement New features or upgrades for functionality, performance, etc
Milestone

Comments

@ifadams
Copy link
Contributor

ifadams commented Sep 10, 2024

Is your feature request related to a problem? Please describe.
Our batch descriptor insert feature (#209) needs more integrated testing for automation and regression checks.

Describe the solution you'd like
We should develop additional end-to-end tests exercising different descriptor engines, as well as additional unit tests to improve coverage.

@ifadams ifadams added the Enhancement New features or upgrades for functionality, performance, etc label Sep 10, 2024
@cwlacewe cwlacewe added this to the v2.11.0 Tasks milestone Sep 10, 2024
@cwlacewe
Copy link
Contributor

To keep track of what's needed:

  • Coverage difference is in src/DescriptorsCommand.cc where 64 lines of code was added but none tested:

image

  • Gap should be resolved by making sure there are C++ tests for AddDescriptor::add_single_descriptor and AddDescriptor::add_descriptor_batch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New features or upgrades for functionality, performance, etc
Projects
None yet
Development

No branches or pull requests

2 participants