Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roadmap: Improve ease of use suggestion #13

Open
mccarthy-m-g opened this issue Nov 18, 2024 · 1 comment
Open

Roadmap: Improve ease of use suggestion #13

mccarthy-m-g opened this issue Nov 18, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@mccarthy-m-g
Copy link
Contributor

Naive layperson food-for-thought question after skimming through some of the docs and codebase:

Could we make use of S3 (or S7 if we want to be forward-looking) classes/methods to improve ease of use (one of the roadmap items for mipdtrial), especially for cross-package functionality in our ecosystem?

As far as the API, maybe we could draw inspiration from tidymodels? (mainly thinking about the pipe-able, build a model in steps approach, which might work well for designing a trial too)


For context: I thought of this while reviewing PR #12, where we might want to have different approaches for different types of models. Using S3 classes might help us formalize how we handle situations like this, and make for clearer code and logic.

@mccarthy-m-g mccarthy-m-g added the enhancement New feature or request label Nov 18, 2024
@roninsightrx
Copy link
Contributor

Agree, making more robust and structured would be nice. Keep in mind though that the "model" concept does touch almost every other package we've created (PKPDsim, PKPDmap, irxanalytics, mipdtrial, PKPDposterior, ...), so there'd be a lot of code to update. If we do this, we should probably implement as optional structure first and keep supporting existing structure for the time being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants