Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sessions can be renewed indefinitely #321

Open
Naviary2 opened this issue Nov 14, 2024 · 1 comment
Open

Sessions can be renewed indefinitely #321

Naviary2 opened this issue Nov 14, 2024 · 1 comment
Labels
vulnerability Presents a security vulnerability waiting for other feature

Comments

@Naviary2
Copy link
Member

Naviary2 commented Nov 14, 2024

Since adding the feature to renew players sessions, if they are active, if a bad actor is able to get a hold of your refresh token now they can indefinitely renew it to always have access to your account.

Proposed solutions:

  • In case that ever happens, in your profile, have a revoke all sessions button that would invalidate and delete all of your refresh tokens from the database.
  • Make your session tokens only valid on the original device (user-agent) they are created on. But this would only work if the browser agent is consistent across every request for all machines, which I'm not sure... ?
@Naviary2 Naviary2 added the vulnerability Presents a security vulnerability label Nov 14, 2024
@Naviary2
Copy link
Member Author

I think this needs to wait until a website overhaul, the profile UI could use an upgrade. For example, showing you a list of your recent games, showing you your elo in various variants, showing you your badges and patron status...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vulnerability Presents a security vulnerability waiting for other feature
Projects
None yet
Development

No branches or pull requests

1 participant