Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8: CSV Export: issue with numeric + CR/line feed #514

Open
Gary-van-Breda opened this issue Apr 24, 2024 · 0 comments
Open

PHP 8: CSV Export: issue with numeric + CR/line feed #514

Gary-van-Breda opened this issue Apr 24, 2024 · 0 comments

Comments

@Gary-van-Breda
Copy link
Contributor

A change has occurred in PHP 8: is_numeric now returns true for any whitespace after the number. This means that the following now returns TRUE from is_numeric, where previously it returned false:
"10
"

This in turn means the logic in function get_csv in file modules/indicia_svc_data/controllers/data_service_base.php is no longer valid: the string above will no longer be wrapped in quotes, breaking the record over 2 lines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant