Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong icon when entering distrobox #559

Open
mkmkme opened this issue Jan 9, 2025 · 1 comment
Open

Wrong icon when entering distrobox #559

mkmkme opened this issue Jan 9, 2025 · 1 comment
Labels
🐛 bug Something isn't working

Comments

@mkmkme
Copy link

mkmkme commented Jan 9, 2025

Describe the bug

I have Fedora 41 machine with distrobox installed. I created a new Ubuntu 24.04 distrobox via

distrobox create --image ubuntu:24:04

Then, I entered the distrobox via distrobox enter ubuntu-24-04. The prompt inside the container still shows Fedora logo for me even though _tide_detect_os returns Ubuntu logo.

Steps to reproduce

  1. Install distrobox
  2. Create a distrobox with a different distro from the host
  3. Enter the distrobox

Screenshots

image

Environment

Output of tide bug-report:

fish version: 3.7.0
tide version: 6.1.1
term: wezterm
os: Ubuntu 24.04
terminal emulator: WezTerm
fish startup: 44.91 millis
fisher plugins: jorgebucaran/fisher ilancosman/tide@v6 edc/bass patrickf1/fzf.fish jhillyerd/plugin-git franciscolourenco/done lilyball/nix-env.fish kenji-miyake/reload.fish jethrokuan/z
@mkmkme mkmkme added the 🐛 bug Something isn't working label Jan 9, 2025
@mkmkme
Copy link
Author

mkmkme commented Jan 13, 2025

This can be easily fixed by adding

_tide_detect_os | read -g --line tide_os_icon tide_os_color tide_os_bg_color

before _tide_print_item in _tide_item_os.fish. It feels hacky though. The proper solution would probably also remove the OS icon/color/bg_color from configuration process as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant