Detail View integration won't work if configured custom command uses other custom vars.

[mkayontour]

TLDR; Custom vars may differ while using a custom command for the detail view integration.

Problem

As stated in the documentation, you can use a custom command name for the detail view integration.
detail-view-integration

But with custom commands are custom vars specific for the command as well. As I'm sure many users have had custom commands of this because some started early to check processes before they were integrated in the ITL.

[...]
        $bpName = $service->customvars['icingacli_businessprocess_config'] ?? null;
[...]
        $nodeName = $service->customvars['icingacli_businessprocess_process'] ?? null;
[...]

icingaweb2-module-businessprocess/library/Businessprocess/ProvidedHook/Icingadb/ServiceDetailExtension.php

Lines 49 to 75 in 3403b60

	$bpName = $service->customvars['icingacli_businessprocess_config'] ?? null;
	if (! $bpName) {
	$bpName = key($this->storage->listProcessNames());
	}
	$nodeName = $service->customvars['icingacli_businessprocess_process'] ?? null;
	if (! $nodeName) {
	return HtmlString::create('');
	}
	$bp = $this->storage->loadProcess($bpName);
	$node = $bp->getBpNode($nodeName);
	IcingaDbState::apply($bp);
	if ($service->customvars['icingaweb_businessprocess_as_tree'] ?? false) {
	$renderer = new TreeRenderer($bp, $node);
	$tag = 'ul';
	} else {
	$renderer = new TileRenderer($bp, $node);
	$tag = 'div';
	}
	$renderer->setUrl(Url::fromPath('businessprocess/process/show?config=' . $bpName . '&node=' . $nodeName));
	$renderer->ensureAssembled()->getFirst($tag)->setAttribute('data-base-target', '_next');
	return (new HtmlDocument())->addHtml(Html::tag('h2', 'Business Process'), $renderer);

Expected behaviour

Have the possibility to allow own custom vars for the detail extension views.

Versions

Businessprocess: 2.5.1

[nilmerg]

As I'm sure many users have had custom commands of this because some started early to check processes before they were integrated in the ITL.

I'm not so sure, icingacli_businessprocess_process was the only option from the beginning.

But it's certainly possible to support custom properties. Someday, or in case a volunteer takes over. 😉

[mkayontour]

Thanks, I'll try to provide a PR. ;)