Feature/icingaweb module graphite #199
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @mkayontour, there's already a release date for this feature? Thanks |
|
Sorry, I don't have a fixed release date - as I'm working on the collection only at spare times. I try to prepare a release before the summit. I can't promise you anything right now. |
|
I did a bit of cleanup and checked if the code is still compatible. |
Donien
approved these changes
Nov 14, 2024
| @@ -3,6 +3,54 @@ | |||
| - name: Converge | |||
| hosts: all | |||
| vars: | |||
| icingaweb2_modules: | |||
| graphite: | |||
| enabled: true | |||
There was a problem hiding this comment.
source missing
Suggested change
| enabled: true | |
| enabled: true | |
| source: package |
Comment on lines
+37
to
+45
| | insecure | number | "1" | | ||
|
|
||
| #### Section ui | ||
|
|
||
| | Variable | Type | Example | | ||
| |-------------------------|--------|---------| | ||
| | default_time_range | number | "1" | | ||
| | defautl_time_range_unit | string | "hours" | | ||
| | disable_no_graphs_found | bool | "0"/"1" | |
There was a problem hiding this comment.
insecure and disable_no_graphs_found should both either be number (or int) or bool, for consistency since both are essentially toggles.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the feature to install and configure Icinga Web 2 Module Graphite.