Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MuSR: 3He Refrigerator Implement Cryogenic Control Logic #6240

Open
5 tasks
JamesKingWork opened this issue Feb 16, 2021 · 15 comments
Open
5 tasks

MuSR: 3He Refrigerator Implement Cryogenic Control Logic #6240

JamesKingWork opened this issue Feb 16, 2021 · 15 comments
Assignees
Labels
3 rework umbrella Umbrella ticket that can have 0 points

Comments

@JamesKingWork
Copy link
Contributor

JamesKingWork commented Feb 16, 2021

As a MuSR scientist, I would like to be able to control the 3He Refrigerator.

Relies on logic being documented and approved from #6239 as well as communications being implemented from #6241.

Acceptance criteria:

  • Approved logic is implemented in the IOC
  • Relevant macros are available to configure the IOC (see the two setup VIs)
  • Logic is tested sufficiently with the IOCTestFramework
  • OPI is corrected to work with the new functionality
  • If the IOC is restarted it should be able to work out what state it was in and continue recondensing If the IOC is restarted we presume we are in a temperature control state, not a recondensing state

Notes:

3He Refrigerator tickets:

@JamesKingWork
Copy link
Contributor Author

Confirmed with cryogenics and MuSR scientists that this is purely ITC503 and doesn't use ITC502s and ITC601s as the LabVIEW suggests

@KathrynBaker KathrynBaker added the 8 label Mar 4, 2021
@kjwoodsISIS kjwoodsISIS added this to the SPRINT_2021_03_04 milestone Mar 4, 2021
@JamesKingWork
Copy link
Contributor Author

Do not implement autorecondensing as part of this ticket.

@rerpha
Copy link
Contributor

rerpha commented Mar 17, 2021

Sticking this in impeded now as we're waiting for more info from cryogenics and for #6239 to be completed.

@JamesKingWork
Copy link
Contributor Author

I am happy that we have enough of the cryogenic logic and communications correct that we can start implementing this

@rerpha
Copy link
Contributor

rerpha commented May 19, 2022

note to self, I will need to sort out the tests to adapt to the fact that part 2 no longer exists

@rerpha
Copy link
Contributor

rerpha commented May 20, 2022

recondensing seems to work now and WISH look to have managed one, but going to get some feedback before putting this in review to see if there are any niggles

@rerpha rerpha added the umbrella Umbrella ticket that can have 0 points label May 31, 2022
@FreddieAkeroyd
Copy link
Member

@rerpha have we had any feedback, is this ready for review?

@rerpha
Copy link
Contributor

rerpha commented Jul 1, 2022

@rerpha have we had any feedback, is this ready for review?

I need to revisit it, recondensing wasn't working very well so need to book some time in the shutdown to test against the device again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 rework umbrella Umbrella ticket that can have 0 points
Projects
None yet
Development

No branches or pull requests

6 participants