Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

report(): Add option to skip conversion to base units #1433

Open
ksbeattie opened this issue Jun 13, 2024 · 2 comments
Open

report(): Add option to skip conversion to base units #1433

ksbeattie opened this issue Jun 13, 2024 · 2 comments
Assignees
@adam-a-a
Labels
Priority:Normal Normal Priority Issue or PR WaterTAP

Comments

@ksbeattie
Copy link
Member

See watertap-org/watertap#1426 for request for an option to skip automatic conversion to base units.
@ksbeattie
Copy link
Member Author

@adam-a-a will you be able to implement this in idaes-pse?

@ksbeattie ksbeattie added the Priority:Normal Normal Priority Issue or PR label Jun 20, 2024
@andrewlee94 andrewlee94 changed the title report(): Add option to skip convertion to base units report(): Add option to skip conversion to base units Nov 4, 2024
@ksbeattie ksbeattie mentioned this issue Nov 21, 2024
Open
@ksbeattie
Copy link
Member Author

@andrewlee94 points out that if unit conversion was more efficient in Pyomo, then report() would have to do less work here. @jsiirola, is this something Pyomo to help with?

Also related to: #682

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adam-a-a adam-a-a

Labels
Priority:Normal Normal Priority Issue or PR WaterTAP
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ksbeattie @adam-a-a