From 66adbfa5694812f0a74f47092b82ce17d7a54190 Mon Sep 17 00:00:00 2001 From: Lauren Li <45975633+lauren-li@users.noreply.github.com> Date: Mon, 16 Oct 2023 11:40:00 -0700 Subject: [PATCH 1/9] Fix PL/I requiredBuildProperties property name (#429) Signed-off-by: Lauren Li <45975633+lauren-li@users.noreply.github.com> --- build-conf/PLI.properties | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build-conf/PLI.properties b/build-conf/PLI.properties index 3fe88ba0e..564f9750b 100644 --- a/build-conf/PLI.properties +++ b/build-conf/PLI.properties @@ -2,7 +2,7 @@ # # Comma separated list of required build properties for PLI.groovy -pli_requiredBuildPropeties=pli_srcPDS,pli_incPDS,pli_objPDS,pli_loadPDS,\ +pli_requiredBuildProperties=pli_srcPDS,pli_incPDS,pli_objPDS,pli_loadPDS,\ pli_compiler,pli_linkEditor,pli_tempOptions,applicationOutputsCollectionName,\ SDFHCOB,SDFHLOAD,SDSNLOAD,SCEELKED, \ pli_dependencySearch From 805b833a133f0e69697aa785213a71e54ac3e7b2 Mon Sep 17 00:00:00 2001 From: Dennis Behm Date: Tue, 17 Oct 2023 15:18:41 +0200 Subject: [PATCH 2/9] Mask potential git credentials in captured git url (#419) * Masking potential git credentials in git url Signed-off-by: Dennis Behm --- utilities/GitUtilities.groovy | 19 +++++++++++++++++-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/utilities/GitUtilities.groovy b/utilities/GitUtilities.groovy index 407eec742..83421aa2c 100644 --- a/utilities/GitUtilities.groovy +++ b/utilities/GitUtilities.groovy @@ -3,6 +3,8 @@ import com.ibm.dbb.metadata.* import com.ibm.dbb.dependency.* import com.ibm.dbb.build.* import groovy.transform.* +import java.util.regex.Matcher +import java.util.regex.Pattern @Field BuildProperties props = BuildProperties.getInstance() @Field MetadataStore metadataStore @@ -174,9 +176,10 @@ def getFileCurrentGitHash(String gitDir, String filePath) { * Returns the current Git url * * @param String gitDir Local Git repository directory - * @return String gitUrl The current Git url + * @return String gitUrl The current masked Git url */ def getCurrentGitUrl(String gitDir) { + String maskedGitUrl = new String() String cmd = "git -C $gitDir config --get remote.origin.url" StringBuffer gitUrl = new StringBuffer() StringBuffer gitError = new StringBuffer() @@ -187,7 +190,19 @@ def getCurrentGitUrl(String gitDir) { if (gitError) { print("*! Error executing Git command: $cmd error: $gitError") } - return gitUrl.toString().trim() + + // Mask credentials that may be added by the pipeline orchestrator + // into the git remote.origin.url configuration + // applies only for http/https configs + // Find // and then take all until the @ char. This is where the PAT is + // stored + String regex = "(?<=.\\/\\/)[^@]*(?=@)"; + String subst = "***"; + Pattern pattern = Pattern.compile(regex, Pattern.MULTILINE); + Matcher matcher = pattern.matcher(gitUrl.toString().trim()); + maskedGitUrl = matcher.replaceAll(subst); + + return maskedGitUrl } From 4512c46f1893b2103a4205018e707822d36a8b5b Mon Sep 17 00:00:00 2001 From: Lauren Li <45975633+lauren-li@users.noreply.github.com> Date: Tue, 17 Oct 2023 08:13:06 -0700 Subject: [PATCH 3/9] Add CopyMode property for Transfer.groovy (#428) * Initial implementation of CopyMode for Transfer.groovy * Update Readme files --------- Signed-off-by: Lauren Li <45975633+lauren-li@users.noreply.github.com> Co-authored-by: Mathieu Dalbin --- build-conf/README.md | 4 ++-- build-conf/Transfer.properties | 4 ++-- languages/Transfer.groovy | 24 +++++++++++++++++--- samples/application-conf/README.md | 3 ++- samples/application-conf/Transfer.properties | 8 ++++++- samples/application-conf/file.properties | 6 +++++ 6 files changed, 40 insertions(+), 9 deletions(-) diff --git a/build-conf/README.md b/build-conf/README.md index 6d47b3ad9..906bc07f4 100644 --- a/build-conf/README.md +++ b/build-conf/README.md @@ -323,8 +323,8 @@ transfer_requiredBuildProperties | Comma separated list of required build proper transfer_srcPDS | Dataset of any type of source transfer_jclPDS | Sample dataset for JCL members transfer_xmlPDS | Sample dataset for xml members -transfer_srcOptions | BPXWDYN creation options for creating 'source' type data sets -transfer_outputDatasets | List of output datasets to document deletions ** Can be overridden by a file property. ** If used for multiple, use a file property to set transfer_outputDatasets +transfer_dsOptions | BPXWDYN creation options for creating 'source' type data sets +transfer_outputDatasets | List of output datasets to document deletions ** Can be overridden by a file property. ** If used for multiple, use a file property to set transfer_outputDatasets ### language-conf/languageConfigProps01.properties Sample language configuration properties file used by dbb-zappbuild/utilities/BuildUtilities.groovy. diff --git a/build-conf/Transfer.properties b/build-conf/Transfer.properties index fd0ae198a..e501c8199 100644 --- a/build-conf/Transfer.properties +++ b/build-conf/Transfer.properties @@ -20,6 +20,6 @@ transfer_xmlPDS=${hlq}.XML # # This is using the DBB PropertyMapping syntax allowing multiple mappings of # target source dataset definitions to the required options -# +# transfer_dsOptions=cyl space(1,1) lrecl(80) dsorg(PO) recfm(F,B) dsntype(library) :: transfer_srcPDS, transfer_jclPDS -transfer_dsOptions=cyl space(1,1) lrecl(144) dsorg(PO) recfm(F,B) dsntype(library) :: transfer_xmlPDS +transfer_dsOptions=cyl space(1,1) lrecl(144) dsorg(PO) recfm(F,B) dsntype(library) :: transfer_xmlPDS \ No newline at end of file diff --git a/languages/Transfer.groovy b/languages/Transfer.groovy index ea899f068..e3c914460 100644 --- a/languages/Transfer.groovy +++ b/languages/Transfer.groovy @@ -83,6 +83,17 @@ buildList.each { buildFile -> props.error = "true" buildUtils.updateBuildResult(errorMsg:errorMsg) } + + // get copy mode value from Property Mappings + def copyMode = props.getFileProperty('transfer_copyMode', buildFile) + + DBBConstants.CopyMode transferCopyMode + if (copyMode != null) { + transferCopyMode = DBBConstants.CopyMode.valueOf(copyMode) + } else { + transferCopyMode = DBBConstants.CopyMode.valueOf("TEXT") + if (props.verbose) println "** No CopyMode found for file '${buildFile}'. Using 'TEXT' as default." + } // allocate target dataset if (!verifiedBuildDatasets.contains(targetDataset)) { // using a cache not to allocate all defined datasets @@ -93,9 +104,16 @@ buildList.each { buildFile -> // copy the file to the target dataset String deployType = buildUtils.getDeployType("transfer", buildFile, null) - try { - int rc = new CopyToPDS().key(buildFile).file(new File(buildUtils.getAbsolutePath(buildFile))).dataset(targetDataset).member(member).output(true).deployType(deployType).execute() - if (props.verbose) println "** Copied $buildFile to $targetDataset with deployType $deployType (rc = $rc)" + try { + int rc = new CopyToPDS().key(buildFile) + .file(new File(buildUtils.getAbsolutePath(buildFile))) + .copyMode(transferCopyMode) + .dataset(targetDataset) + .member(member) + .output(true) + .deployType(deployType) + .execute() + if (props.verbose) println "** Copied $buildFile to $targetDataset with copyMode $transferCopyMode and deployType $deployType (rc = $rc)" if (rc!=0){ String errorMsg = "*! The CopyToPDS return code ($rc) for $buildFile exceeded the maximum return code allowed (0)." diff --git a/samples/application-conf/README.md b/samples/application-conf/README.md index 6bea3757d..cc1e10d03 100644 --- a/samples/application-conf/README.md +++ b/samples/application-conf/README.md @@ -291,12 +291,13 @@ rexx_cexec_deployType | default deployType CEXEC | true rexx_compileSyslibConcatenation | A comma-separated list of libraries to be concatenated in syslib during compile step | true rexx_linkEditSyslibConcatenation | A comma-separated list of libraries to be concatenated in syslib during linkEdit step | true -### nonBuildable.properties +### Transfer.properties Application properties used by zAppBuild/language/Transfer.groovy Property | Description | Overridable --- | --- | --- transfer_deployType | deployType | true +transfer_copyMode | Copy mode used during the copy to the target data set | true ### languageConfigurationMapping.properties Sample language configuration mapping properties used by dbb-zappbuild/utilities/BuildUtilities.groovy. diff --git a/samples/application-conf/Transfer.properties b/samples/application-conf/Transfer.properties index 04b7480e3..84bc44ed9 100644 --- a/samples/application-conf/Transfer.properties +++ b/samples/application-conf/Transfer.properties @@ -2,4 +2,10 @@ # # default deployType -transfer_deployType=TRANSFER \ No newline at end of file +transfer_deployType=TRANSFER + +# +# Default copy mode to transfer the file to the target library +# Available modes are ASA_TEXT, BINARY, LOAD, and TEXT +# Documentation: https://www.ibm.com/docs/api/v1/content/SS6T76_2.0.0/javadoc/com/ibm/dbb/build/DBBConstants.CopyMode.html +transfer_copyMode=TEXT \ No newline at end of file diff --git a/samples/application-conf/file.properties b/samples/application-conf/file.properties index 3b27d10da..fd035353b 100644 --- a/samples/application-conf/file.properties +++ b/samples/application-conf/file.properties @@ -70,3 +70,9 @@ dbb.scriptMapping = CRB.groovy :: **/crb/*.yaml # # transfer_deployType = JCL :: **/*.jcl # transfer_deployType = XML :: **/xml/*.* + +# +# Override of the default copy mode to transfer the file to the target library +# Available modes are ASA_TEXT, BINARY, LOAD, and TEXT +# Documentation: https://www.ibm.com/docs/api/v1/content/SS6T76_2.0.0/javadoc/com/ibm/dbb/build/DBBConstants.CopyMode.html +# transfer_copyMode=BINARY :: **/*.object \ No newline at end of file From 2f125d1e302af31e4c8231e1d05b2cb30e818b9c Mon Sep 17 00:00:00 2001 From: Mathieu Dalbin Date: Tue, 17 Oct 2023 17:22:34 +0200 Subject: [PATCH 4/9] Move to 24-h date-time format and adding decorations (#425) * Update the date format to use 24-h format. * Adding decorations for the major phases of build process Signed-off-by: Mathieu Dalbin --- build-conf/README.md | 1 - build-conf/build.properties | 24 +++++++++--------------- build.groovy | 13 +++++++------ 3 files changed, 16 insertions(+), 22 deletions(-) diff --git a/build-conf/README.md b/build-conf/README.md index 906bc07f4..d60a5218d 100644 --- a/build-conf/README.md +++ b/build-conf/README.md @@ -41,7 +41,6 @@ applicationDefaultPropFiles | Comma separated list of default application confi buildListFileExt | File extension that indicates the build file is really a build list. applicationConfRootDir | Alternate root directory for application-conf location. Allows for the deployment of the application-conf directories to a static location. Defaults to ${workspace}/${application} createBuildOutputSubfolder | Option to create a subfolder with the build label within the build output dir (outDir). Default: true. -buildOutputTSformat | Defines the build timestamp format for build output subfolder and build label. requiredDBBToolkitVersion | Minimum required DBB ToolkitVersion to run this version of zAppBuild. requiredBuildProperties | Comma separated list of required build properties for zAppBuild/build.groovy. Build and language scripts will validate that *required* build properties have been set before the script runs. If any are missing or empty, then a validation error will be thrown. dbb.file.tagging | Controls compile log and build report file tagging. Default: true. diff --git a/build-conf/build.properties b/build-conf/build.properties index 6cc30fde1..60d0d5c34 100644 --- a/build-conf/build.properties +++ b/build-conf/build.properties @@ -14,7 +14,7 @@ # Supports both relative path (to zAppBuild/build-conf/) and absolute path # # These properties files expect to contain centrally managed defaults -# such as system datasets, language script specific settings +# such as system datasets, language script specific settings # buildPropFiles=datasets.properties,dependencyReport.properties,Assembler.properties,BMS.properties,\ MFS.properties,PSBgen.properties,DBDgen.properties,ACBgen.properties,Cobol.properties,\ @@ -24,14 +24,14 @@ CRB.properties,zCEE3.properties # # Comma separated list of default application configuration property files to load # Supports both relative path (to zAppBuild/build-conf/) and absolute path -# +# # These properties files expect to contain centrally managed defaults # and also may reference properties files containing configuration -# of the language script configurations such as return codes, deploy types -# +# of the language script configurations such as return codes, deploy types +# # See also application-conf/application.properties#applicationPropFiles -# -# default: +# +# default: # applicationDefaultPropFiles=defaultzAppBuildConf.properties # # extended sample to set default language script configurations: @@ -45,7 +45,7 @@ CRB.properties,zCEE3.properties # default-application-conf/Transfer.properties,\ # default-application-conf/LinkEdit.properties,\ # default-application-conf/ZunitConfig.properties -# +# applicationDefaultPropFiles=defaultzAppBuildConf.properties # @@ -58,7 +58,7 @@ applicationDefaultPropFiles=defaultzAppBuildConf.properties # a sample of the application-conf can be found in # samples/application-conf # -# zAppBuild expects a file called application.properties in this directory. +# zAppBuild expects a file called application.properties in this directory. # # The property also allows for the deployment of # the application-conf directories to an alternate location rather @@ -69,7 +69,7 @@ applicationDefaultPropFiles=defaultzAppBuildConf.properties # based on workspace + application and application-conf # # applicationConfDir=${workspace}/${application}/application-conf -# +# # # Example: Static location on USS # applicationConfDir=/u/build/config/applications/${application}/application-conf @@ -101,12 +101,6 @@ buildListFileExt=txt # Default: true createBuildOutputSubfolder=true -# -# Build Timestamp Format -# Applies to all build types except userBuild -# Default: yyyyMMdd.HHmmss.mmm - See Date format method pattern strings -buildOutputTSformat=yyyyMMdd.HHmmss.mmm - # # Minimum required DBB ToolkitVersion to run this version of zAppBuild # Build initialization process validates the DBB Toolkit Version in use and matches that against this setting diff --git a/build.groovy b/build.groovy index 03ae50e86..984298f71 100644 --- a/build.groovy +++ b/build.groovy @@ -27,7 +27,7 @@ import groovy.cli.commons.* @Field startTime = new Date() // start time message -props.startTime = startTime.format("yyyyMMdd.hhmmss.mmm") +props.startTime = startTime.format("yyyyMMdd.HHmmss.SSS") println("\n** Build start at $props.startTime") // initialize build @@ -89,7 +89,7 @@ if (props.error) //******************************************************************** def initializeBuildProcess(String[] args) { - if (props.verbose) println "** Initializing build process . . ." + println "**************** Initialization of the build process ****************" def opts = parseArgs(args) // parse incoming options and arguments populateBuildProperties(opts) // build properties initial set @@ -294,8 +294,8 @@ options: System.exit(1) } - if(opts.v && args.size() > 1) - println "** Input args = ${args[1..-1].join(' ')}" + if(opts.v && args.size() > 0) + println "** Input args = ${args[0..-1].join(' ')}" if( (!opts.cch && opts.ccp) || (opts.cch && !opts.ccp) ) { println "** --cccHost and --cccPort options are mutual" @@ -490,7 +490,7 @@ def populateBuildProperties(def opts) { props.topicBranchBuild = (props.applicationCurrentBranch.equals(props.mainBuildBranch)) ? null : 'true' props.applicationBuildGroup = ((props.applicationCurrentBranch) ? "${props.application}-${props.applicationCurrentBranch}" : "${props.application}") as String - props.applicationBuildLabel = ("build." + ( (props.buildOutputTSformat) ? startTime.format("${props.buildOutputTSformat}") : "${props.startTime}" ) ) as String + props.applicationBuildLabel = ("build.${props.startTime}") as String props.applicationCollectionName = ((props.applicationCurrentBranch) ? "${props.application}-${props.applicationCurrentBranch}" : "${props.application}") as String props.applicationOutputsCollectionName = "${props.applicationCollectionName}-outputs" as String @@ -526,6 +526,7 @@ def populateBuildProperties(def opts) { * - build text file: Contains a list of programs from a text file. Provide a *.txt build file argument. */ def createBuildList() { + println "************* Creation and processing of the build list *************" // using a set to create build list to eliminate duplicate files Set buildSet = new HashSet() @@ -671,7 +672,7 @@ def createBuildList() { def finalizeBuildProcess(Map args) { - + println "***************** Finalization of the build process *****************" def buildReport = BuildReportFactory.getBuildReport() def buildResult = null From c2bcfcc0752d6d6d24bb62a139d9b4dbf9b12d19 Mon Sep 17 00:00:00 2001 From: Dennis Behm Date: Wed, 18 Oct 2023 14:41:11 +0200 Subject: [PATCH 5/9] Improve calculation of branch name in detached head scenario (#435) * Improve calculation of branch name in detached head scenario Signed-off-by: Dennis Behm --- utilities/GitUtilities.groovy | 26 +++++++++++++++++++++----- 1 file changed, 21 insertions(+), 5 deletions(-) diff --git a/utilities/GitUtilities.groovy b/utilities/GitUtilities.groovy index 83421aa2c..d5fdb41e9 100644 --- a/utilities/GitUtilities.groovy +++ b/utilities/GitUtilities.groovy @@ -73,15 +73,31 @@ def getCurrentGitDetachedBranch(String gitDir) { } String gitBranchString = gitBranch.toString() - def gitBranchArr = gitBranchString.split(',') + String[] gitBranchesArray = gitBranchString.split(',') def solution = "" - for (i = 0; i < gitBranchArr.length; i++) { - if (gitBranchArr[i].contains("origin/")) { - solution = gitBranchArr[i].replaceAll(".*?/", "").trim() + // expecting references with "origin" as segment + def origin = "origin/" + if (gitBranchesArray.count {it.contains(origin)} > 1 ) { + String warningMsg = "*! (GitUtils.getCurrentGitDetachedBranch) Warning obtaining branch name for ($dir). Multiple references point to the same commit. ($gitBranchArr)" + println(warningMsg) + updateBuildResult(warningMsg:warningMsg) + } + + // substring the branch name + for (i = 0; i < gitBranchesArray.length; i++) { + if (gitBranchesArray[i].contains(origin)) { + solution = gitBranchesArray[i].replaceAll(".*?${origin}", "").trim() } } - return (solution != "") ? solution : println("*! Error parsing branch name: $gitBranch") + if (solution != "") { // return branch name + return solution + } else { + String errorMsg = "*! (GitUtils.getCurrentGitDetachedBranch) Error extracting current branch name: $gitBranch. Expects a origin/ segment." + println(errorMsg) + props.error = "true" + updateBuildResult(errorMsg:errorMsg) + } } /* From 79beff46196911fda13247852cd768d2c0554e89 Mon Sep 17 00:00:00 2001 From: Dennis Behm Date: Wed, 18 Oct 2023 17:27:47 +0200 Subject: [PATCH 6/9] Introduce SDSNEXIT library for Assembler, Cobol and PLI language script (#437) * Add SDSNEXIT to compile steps and configuration files Signed-off-by: Dennis Behm --- build-conf/README.md | 1 + build-conf/datasets.properties | 3 +++ languages/Assembler.groovy | 8 +++++++- languages/Cobol.groovy | 4 +++- languages/PLI.groovy | 4 +++- 5 files changed, 17 insertions(+), 3 deletions(-) diff --git a/build-conf/README.md b/build-conf/README.md index d60a5218d..762c24254 100644 --- a/build-conf/README.md +++ b/build-conf/README.md @@ -28,6 +28,7 @@ SCSQCOBC | MQ COBOL Library. Example: CSQ.V9R1M0.SCSQCOBC SCSQPLIC | MQ PLI Library. Example: CSQ.V9R1M0.SCSQPLIC SCSQLOAD | MQ Load Library. Example: CSQ.V9R1M0.SCSQLOAD SDSNLOAD | DB2 Load Library. Example: DB2.V9R1M0.SDSNLOAD +SDSNEXIT | DB2 Exit Library. Example: DBC0CFG.SDSNEXIT SFELLOAD | Optional IDz Load Library. Example: FEL.V14R0M0.SFELLOAD SBZUSAMP | Optional z/OS Dynamic Test Runner IDz zUnit / WAZI VTP library containing necessary copybooks. Example : FEL.V14R2.SBZUSAMP diff --git a/build-conf/datasets.properties b/build-conf/datasets.properties index 28b407e30..ad5d366c8 100644 --- a/build-conf/datasets.properties +++ b/build-conf/datasets.properties @@ -51,6 +51,9 @@ SCSQLOAD= # DB2 Load Library. Example: DB2.V9R1M0.SDSNLOAD SDSNLOAD= +# DB2 Exit Library. Example: DBC0CFG.SDSNEXIT +SDSNEXIT= + # IMS Macro Library. Example: DFS.V11R1M0.SDFSMAC SDFSMAC= diff --git a/languages/Assembler.groovy b/languages/Assembler.groovy index e071acbb2..0a22f10b6 100644 --- a/languages/Assembler.groovy +++ b/languages/Assembler.groovy @@ -213,8 +213,14 @@ def createAssemblerSQLTranslatorCommand(String buildFile, LogicalFile logicalFil assembler_SQLtranslator.dd(new DDStatement().name("SYSCIN").dsn("&&SYSCIN").options('cyl space(5,5) unit(vio) new').pass(true)) // steplib - assembler_SQLtranslator.dd(new DDStatement().name("TASKLIB").dsn(props.SDSNLOAD).options("shr")) + if (props.SDSNEXIT) { + assembler_SQLtranslator.dd(new DDStatement().name("TASKLIB").dsn(props.SDSNEXIT).options("shr")) + assembler_SQLtranslator.dd(new DDStatement().dsn(props.SDSNLOAD).options("shr")) + } else { + assembler_SQLtranslator.dd(new DDStatement().name("TASKLIB").dsn(props.SDSNLOAD).options("shr")) + } + assembler_SQLtranslator.dd(new DDStatement().name("SYSUT1").options(props.assembler_tempOptions)) // sysprint diff --git a/languages/Cobol.groovy b/languages/Cobol.groovy index 4479e81fd..1fdf48ade 100644 --- a/languages/Cobol.groovy +++ b/languages/Cobol.groovy @@ -261,8 +261,10 @@ def createCompileCommand(String buildFile, LogicalFile logicalFile, String membe compile.dd(new DDStatement().name("TASKLIB").dsn(props."SIGYCOMP_$compilerVer").options("shr")) if (buildUtils.isCICS(logicalFile)) compile.dd(new DDStatement().dsn(props.SDFHLOAD).options("shr")) - if (buildUtils.isSQL(logicalFile)) + if (buildUtils.isSQL(logicalFile)) { + if (props.SDSNEXIT) compile.dd(new DDStatement().dsn(props.SDSNEXIT).options("shr")) compile.dd(new DDStatement().dsn(props.SDSNLOAD).options("shr")) + } if (props.SFELLOAD) compile.dd(new DDStatement().dsn(props.SFELLOAD).options("shr")) diff --git a/languages/PLI.groovy b/languages/PLI.groovy index bb4cc396d..34a90cf90 100644 --- a/languages/PLI.groovy +++ b/languages/PLI.groovy @@ -222,8 +222,10 @@ def createCompileCommand(String buildFile, LogicalFile logicalFile, String membe compile.dd(new DDStatement().name("TASKLIB").dsn(props."IBMZPLI_$compilerVer").options("shr")) if (buildUtils.isCICS(logicalFile)) compile.dd(new DDStatement().dsn(props.SDFHLOAD).options("shr")) - if (buildUtils.isSQL(logicalFile)) + if (buildUtils.isSQL(logicalFile)) { + if (props.SDSNEXIT) compile.dd(new DDStatement().dsn(props.SDSNEXIT).options("shr")) compile.dd(new DDStatement().dsn(props.SDSNLOAD).options("shr")) + } if (props.SFELLOAD) compile.dd(new DDStatement().dsn(props.SFELLOAD).options("shr")) From 6bb1fe05eb884c4181dbaa1ca03a3735a5766f1b Mon Sep 17 00:00:00 2001 From: Dennis Behm Date: Thu, 19 Oct 2023 20:09:46 +0200 Subject: [PATCH 7/9] Update MFS.groovy declaring the map as output (#436) * Update MFS.groovy declaring the map as output * Update default deployType for MFS.groovy Signed-off-by: Dennis Behm --- languages/MFS.groovy | 52 +++++++++++++++---------- samples/application-conf/MFS.properties | 7 +++- samples/application-conf/README.md | 1 + 3 files changed, 39 insertions(+), 21 deletions(-) diff --git a/languages/MFS.groovy b/languages/MFS.groovy index c03f1b839..c0015a830 100644 --- a/languages/MFS.groovy +++ b/languages/MFS.groovy @@ -4,7 +4,7 @@ import com.ibm.dbb.dependency.* import com.ibm.dbb.build.* import groovy.transform.* -// docs: https://www.ibm.com/support/knowledgecenter/en/SSEPH2_13.1.0/com.ibm.ims13.doc.sur/ims_mfslangbatchmd.htm +// docs: https://www.ibm.com/docs/en/ims/14.1.0?topic=dfsupaa0-running-utility-in-standard-mode // define script properties @Field BuildProperties props = BuildProperties.getInstance() @@ -34,14 +34,17 @@ sortedList.each { buildFile -> File logFile = new File( props.userBuild ? "${props.buildOutDir}/${member}.log" : "${props.buildOutDir}/${member}.mfs.log") if (logFile.exists()) logFile.delete() - MVSExec phase1 = createPhase1Command(buildFile, member, logFile) - MVSExec phase2 = createPhase2Command(buildFile, member, logFile) - + + // execution flags + phase2Execution = props.getFileProperty('mfs_phase2Execution', buildFile) + // execute mvs commands in a mvs job MVSJob job = new MVSJob() job.start() - // preprocess mfs map + // generate phase1 command + MVSExec phase1 = createPhase1Command(buildFile, member, logFile) + int rc = phase1.execute() int maxRC = props.getFileProperty('mfs_phase1MaxRC', buildFile).toInteger() @@ -53,19 +56,24 @@ sortedList.each { buildFile -> buildUtils.updateBuildResult(errorMsg:errorMsg,logs:["${member}.log":logFile]) } else { + // generate phase2 command + if (phase2Execution && phase2Execution.toBoolean()) { + + MVSExec phase2 = createPhase2Command(buildFile, member, logFile) + + rc = phase2.execute() + maxRC = props.getFileProperty('mfs_phase2MaxRC', buildFile).toInteger() - rc = phase2.execute() - maxRC = props.getFileProperty('mfs_phase2MaxRC', buildFile).toInteger() + if (rc > maxRC) { + String errorMsg = "*! The phase 2 return code ($rc) for $buildFile exceeded the maximum return code allowed ($maxRC)" + println(errorMsg) + props.error = "true" + buildUtils.updateBuildResult(errorMsg:errorMsg,logs:["${member}.log":logFile]) + } - if (rc > maxRC) { - String errorMsg = "*! The phase 2 return code ($rc) for $buildFile exceeded the maximum return code allowed ($maxRC)" - println(errorMsg) - props.error = "true" - buildUtils.updateBuildResult(errorMsg:errorMsg,logs:["${member}.log":logFile]) } } - // clean up passed DD statements job.stop() @@ -81,6 +89,9 @@ sortedList.each { buildFile -> /* * createPhase1Command - creates a MVSExec command for preprocessing the MFS Map (buildFile) + * + * defines the MFS map as output. + * */ def createPhase1Command(String buildFile, String member, File logFile) { @@ -91,11 +102,15 @@ def createPhase1Command(String buildFile, String member, File logFile) { // define the MVSExec command to compile the mfs map MVSExec mfsPhase1 = new MVSExec().file(buildFile).pgm(props.mfs_phase1processor).parm(parameters) - mfsPhase1.dd(new DDStatement().name("SYSIN").dsn("${props.mfs_srcPDS}($member)").options("shr").report(true)) + // add DD statements to the mfsPhase2 command + String deployType = buildUtils.getDeployType("mfs", buildFile, null) + + mfsPhase1.dd(new DDStatement().name("SYSIN").dsn("${props.mfs_srcPDS}($member)").options("shr").report(true).output(true).deployType(deployType)) - mfsPhase1.dd(new DDStatement().name("REFIN").dsn(props.REFERAL).options("shr")) + mfsPhase1.dd(new DDStatement().name("REFIN").dsn("&&REFERAL").options("${props.mfs_tempOptions} dir(10) lrecl(80) blksize(800) recfm(f,b)")) mfsPhase1.dd(new DDStatement().name("REFOUT").dsn("&&TEMPPDS").options("${props.mfs_tempOptions} dir(5) lrecl(80) recfm(f,b)")) - mfsPhase1.dd(new DDStatement().name("REFRD").dsn(props.REFERAL).options("shr")) + mfsPhase1.dd(new DDStatement().name("REFRD").dsn("&&TEMPPDS").options("cyl space(5,5) unit(vio) old")) + mfsPhase1.dd(new DDStatement().dsn("&&REFERAL").options("cyl space(5,5) unit(vio) old")) mfsPhase1.dd(new DDStatement().name("SYSPRINT").options(props.mfs_tempOptions)) mfsPhase1.dd(new DDStatement().name("SEQBLKS").dsn("&&SEQBLK").options(props.mfs_tempOptions).pass(true)) @@ -128,10 +143,7 @@ def createPhase2Command(String buildFile, String member, File logFile) { // define the MVSExec command for MFS Language Utility - Phase 2 MVSExec mfsPhase2 = new MVSExec().file(buildFile).pgm(props.mfs_phase2processor).parm(parameters) - // add DD statements to the mfsPhase2 command - String deployType = buildUtils.getDeployType("mfs", buildFile, null) - - mfsPhase2.dd(new DDStatement().name("FORMAT").dsn(props.mfs_tformatPDS).options("shr").output(true).deployType(deployType)) + mfsPhase2.dd(new DDStatement().name("FORMAT").dsn(props.mfs_tformatPDS).options("shr")) // mfsPhase2.dd(new DDStatement().name("DUMMY").dsn("${props.PROCLIB}(FMTCPY)").options("shr")) mfsPhase2.dd(new DDStatement().name("TASKLIB").dsn(props.SDFSRESL).options("shr")) diff --git a/samples/application-conf/MFS.properties b/samples/application-conf/MFS.properties index 4f82dbdf1..2479cd7af 100644 --- a/samples/application-conf/MFS.properties +++ b/samples/application-conf/MFS.properties @@ -11,6 +11,11 @@ mfs_fileBuildRank= mfs_phase1MaxRC=4 mfs_phase2MaxRC=4 +# +# skip execution of phase2 translation +# always execute phase 1 conversion for syntax validation +# can be overridden by file properties +mfs_phase2Execution=false # # default MFS parameters @@ -24,4 +29,4 @@ mfs_impactPropertyList=mfs_phase1Parms,mfs_phase2Parms # # default deployType -mfs_deployType=MFSMAPLOAD \ No newline at end of file +mfs_deployType=MFSSOURCE \ No newline at end of file diff --git a/samples/application-conf/README.md b/samples/application-conf/README.md index cc1e10d03..9606c442b 100644 --- a/samples/application-conf/README.md +++ b/samples/application-conf/README.md @@ -208,6 +208,7 @@ Property | Description | Overridable mfs_fileBuildRank | Default MFS program build rank. Used to sort MFS build file sub-list. Leave empty. | true mfs_phase1MaxRC | Default MFS Phase 1 maximum RC allowed. | true mfs_phase2MaxRC | Default MFS Phase 2 maximum RC allowed. | true +mfs_phase2Execution | Flag if MFS Phase 2 process should be executed. Default: false | true mfs_phase1Parms | Default parameters for the phase 1 step. | true mfs_phase2Parms | Default parameters for the phase 2 step. | true mfs_impactPropertyList | List of build properties causing programs to rebuild when changed | false From ba85e3d63c220aa5569bb0f9a5b2a60d778fbc39 Mon Sep 17 00:00:00 2001 From: Mathieu Dalbin Date: Fri, 20 Oct 2023 09:20:37 +0200 Subject: [PATCH 8/9] Updated CRB definitions with BMS Map EPSMLIS (#439) Signed-off-by: Mathieu Dalbin --- samples/MortgageApplication/crb/cics-resourcesDef.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/samples/MortgageApplication/crb/cics-resourcesDef.yaml b/samples/MortgageApplication/crb/cics-resourcesDef.yaml index b87bcc2ae..408d1ad1e 100644 --- a/samples/MortgageApplication/crb/cics-resourcesDef.yaml +++ b/samples/MortgageApplication/crb/cics-resourcesDef.yaml @@ -2,6 +2,9 @@ resourceDefinitions: - mapset: name: EPSMORT group: EPSMTM +- mapset: + name: EPSMLIS + group: EPSMTM - program: name: EPSCMORT group: EPSMTM From c883d42e647d22b47f3da94bb29561e74e16e3a5 Mon Sep 17 00:00:00 2001 From: Dennis Behm Date: Fri, 20 Oct 2023 09:23:02 +0200 Subject: [PATCH 9/9] Adding version file for zAppBuild (#438) Signed-off-by: Dennis Behm --- version.properties | 1 + 1 file changed, 1 insertion(+) create mode 100644 version.properties diff --git a/version.properties b/version.properties new file mode 100644 index 000000000..48f92f7d9 --- /dev/null +++ b/version.properties @@ -0,0 +1 @@ +version=3.5.0 \ No newline at end of file