Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit of temperature contains special character #98

Open
phackstock opened this issue May 17, 2024 · 6 comments
Open

Unit of temperature contains special character #98

phackstock opened this issue May 17, 2024 · 6 comments
Assignees

Comments

@phackstock
Copy link
Contributor

When recently updating a project to common-definitions I was surprised to see that we use °C as the unit of temperature instead of Celsius.
I would advocate for using Celsius since it avoids using special characters.
Would love to hear your thoughts @IAMconsortium/common-definitions-coordination.

@phackstock phackstock self-assigned this May 17, 2024
@strefler
Copy link

Agree, °C is difficult. We could use either K or Celsius

@orichters
Copy link
Contributor

orichters commented May 21, 2024

I don't like Celsius alone because I think degree should somehow be part of the unit, but strongly discourage using °. I would prefer K as it is clean, short, the SI unit, used by the MAGICC reporting and also not prone to error (I was recently very surprised to the Mongolia's very low warming in high emission scenarios when I realized that was just average temperature of ~0.8°C.)

@danielhuppmann
Copy link
Member

One consideration is that this unit will be used as default in visualizations like the Scenario Explorer, so I'd keep something that is as intuitive as possible for a wide user group - so not K.

There is known issue in the ixmp package which made using °C a bit cumbersome, but this will be solved as we move to ixmp4. And unicode-problems should also be not a major concern in python/R/csv...

My personal preference here would be to only make changes when there is a strong case for it (which I don't quite see).

@orichters
Copy link
Contributor

I remember having some issues opening IIASA csv data files in Excel if they were written by some Linux system before (the units showed as \u00B0C or one times even \u00C2\u00B0C). So that is some concern.

And we already moved away from US$2010 (AR6 unit) to USD_2010to avoid special character issues, and$` is even part of ASCII.

@danielhuppmann
Copy link
Member

I remember having some issues opening IIASA csv data files in Excel if they were written by some Linux system before (the units showed as \u00B0C or one times even \u00C2\u00B0C).

This will be fixed with migrating to the ixmp4 infrastructure.

And we already moved away from US$2010 (AR6 unit) to USD_2010to avoid special character issues, and$` is even part of ASCII.

This was specifically changed to allow unit-conversion with the iam-units package (https://github.com/IAMconsortium/units), because the underlying pint package does not allow $. But I don't see why we would convert units regarding temperature.

@orichters
Copy link
Contributor

orichters commented May 23, 2024

This will be fixed with migrating to the ixmp4 infrastructure.

Might be, on your side, but we always had issues in our mappings of REMIND to project variables with it that needed fixing. Might be similar for other people either working with the data or preparing submissions. I would be really happy if it ° went away. We had issues if files were written in ASCII format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants