Encourage alignment of statements

[mkristien]

This can be in variable declarations or statements:

constexpr uint16_t kIdBase      = 300;
constexpr int      kIdIncrement = 10;
constexpr double   kIdSize      = 5;

vs

constexpr uint16_t kIdBase = 300;
constexpr int kIdIncrement = 10;
constexpr double kIdSize = 5;

[georgeka98]

First one looks cleaner and easier to read. I vote for first style.

[brano2]

It is harder to maintain but that is usually outweighed by the better readability so 👍

[neilweidinger]

I think maybe if one needs to define more than five or so variables at once then yes, this style would make sense, but for simple one liners this would just be unnecessary. Also looks very old school imo.

[brano2]

It makes no difference for one liners. I'd definitely make it a recommendation rather than a strict rule. If you only have 2-3 variables that are completely unrelated, it probably doesn't make sense. But for the cases like above (which are fairly common), it improves readability quite a bit.

[brano2]

Also looks very old school imo.

Says someone who uses vim as their primary text editor.

[neilweidinger]

Says someone who uses vim as their primary text editor.

Vim is timeless 😛

[brano2]

@mkristien can you get your vote in as well so it's clear we have a difference of +3? Then someone create a PR.