Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: OPTIC-1219: Add <title> and favicon variables to the whitelabel config #6528

Merged
merged 7 commits into from
Oct 22, 2024

Conversation

yyassi-heartex
Copy link
Contributor

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

Describe the reason for change

standardizing how we set the page title and favicon in the templates

@github-actions github-actions bot added the feat label Oct 16, 2024
Copy link

netlify bot commented Oct 16, 2024

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit 45e6779
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/6717dce59c391d0008e6eee2

Copy link

netlify bot commented Oct 16, 2024

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit 45e6779
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/6717dce5bf45cb00085320d5

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.66%. Comparing base (47d1a2f) to head (45e6779).
Report is 7 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #6528   +/-   ##
========================================
  Coverage    76.66%   76.66%           
========================================
  Files          169      169           
  Lines        13772    13772           
========================================
  Hits         10558    10558           
  Misses        3214     3214           
Flag Coverage Δ
pytests 76.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yyassi-heartex
Copy link
Contributor Author

yyassi-heartex commented Oct 18, 2024

/git merge develop

Workflow run
Error: Workflow failed

@yyassi-heartex
Copy link
Contributor Author

yyassi-heartex commented Oct 21, 2024

/git merge develop

Workflow run
Successfully merged: create mode 100644 web/libs/editor/tests/integration/e2e/relations/audio.cy.ts

@robot-ci-heartex
Copy link
Collaborator

Follow Merge downstream workflow has been failed.

Workflow run

1 similar comment
@robot-ci-heartex
Copy link
Collaborator

Follow Merge downstream workflow has been failed.

Workflow run

@yyassi-heartex
Copy link
Contributor Author

yyassi-heartex commented Oct 21, 2024

/git merge develop

Workflow run
Successfully merged: Already up to date.

@yyassi-heartex
Copy link
Contributor Author

yyassi-heartex commented Oct 22, 2024

/git merge develop

Workflow run
Successfully merged: Already up to date.

@yyassi-heartex
Copy link
Contributor Author

yyassi-heartex commented Oct 22, 2024

/git merge develop

Workflow run
Successfully merged: 10 files changed, 34 insertions(+), 15 deletions(-)

@yyassi-heartex yyassi-heartex merged commit 8c29520 into develop Oct 22, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants