Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: LEAP-1490: Fix AudioUltra working with relations and comments #6494

Merged
merged 9 commits into from
Oct 21, 2024

Conversation

Gondragos
Copy link
Collaborator

@Gondragos Gondragos commented Oct 9, 2024

This PR fixes the way AudioUltra works with Relations and linking comments (it didn't work and that was a regression), and some small bugs related to AudioUltra itself.

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

What feature flags were used to cover this change?

N/A

Does this PR introduce a breaking change?

(check only one)

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

It shouldn't be like that if I don't break something.

What level of testing was included in the change?

(check all that apply)

  • e2e
  • integration
  • unit

Which logical domain(s) does this change affect?

Audio, AudioUltra, Relations, LinkingModes, Comments

@github-actions github-actions bot added the fix label Oct 9, 2024
Copy link

netlify bot commented Oct 9, 2024

Deploy Preview for heartex-docs ready!

Name Link
🔨 Latest commit 86ba083
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/67165dcce485b20008d8287c
😎 Deploy Preview https://deploy-preview-6494--heartex-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 9, 2024

Deploy Preview for label-studio-docs-new-theme ready!

Name Link
🔨 Latest commit 86ba083
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/67165dcc2a5cef0008b3c545
😎 Deploy Preview https://deploy-preview-6494--label-studio-docs-new-theme.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@bmartel bmartel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 😎, just a suggestion on the snake_case -> camelCase, but logically speaking that won't affect this getting tested. Accidentally approved prematurely, taking this back to when the PR is considered for review officially.

@bmartel bmartel self-requested a review October 9, 2024 19:00
@Gondragos
Copy link
Collaborator Author

Gondragos commented Oct 16, 2024

/git merge develop

Workflow run
Successfully merged: Already up to date.

@robot-ci-heartex
Copy link
Collaborator

Follow Merge downstream workflow has been failed.

Workflow run

@Gondragos
Copy link
Collaborator Author

Gondragos commented Oct 17, 2024

/git merge develop

Workflow run
Successfully merged: 21 files changed, 386 insertions(+), 224 deletions(-)

Copy link
Contributor

@bmartel bmartel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work 🔥

Co-authored-by: bmartel <[email protected]>
@Gondragos
Copy link
Collaborator Author

Gondragos commented Oct 21, 2024

/git merge develop

Workflow run
Successfully merged: delete mode 100644 web/libs/datamanager/src/components/Label/Toolbar/Toolbar.scss

@Gondragos Gondragos enabled auto-merge (squash) October 21, 2024 13:58
@Gondragos Gondragos merged commit 6c2e4ea into develop Oct 21, 2024
33 checks passed
@Gondragos Gondragos deleted the fb-leap-1490/audioultra-vs-overlays branch October 21, 2024 14:29
@robot-ci-heartex
Copy link
Collaborator

Follow Merge downstream workflow has been failed.

Workflow run

2 similar comments
@robot-ci-heartex
Copy link
Collaborator

Follow Merge downstream workflow has been failed.

Workflow run

@robot-ci-heartex
Copy link
Collaborator

Follow Merge downstream workflow has been failed.

Workflow run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants